Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes by others repos #1

Open
hussani opened this issue Jul 14, 2013 · 8 comments
Open

Merge changes by others repos #1

hussani opened this issue Jul 14, 2013 · 8 comments

Comments

@hussani
Copy link
Collaborator

hussani commented Jul 14, 2013

With the conflict generated by me not send PR to root, what you thing about reset your repo to this commit and merge the changes by git pull?
Actually exists other repo on constant updates, you can pull the changes from there too.
We need to know if the ours project will remain following the same path, because it will become unfeasible to maintain a sync it when we take different paths.
You think of any changelog or something?

@jbrooksuk
Copy link
Owner

I'm happy to rollback my changes, merge yours and then put my new changes back in.

If you're unhappy with the colours, or whatever, then you should rename your project to something else, as the Oblivion theme originates from TextMate. I like your new colours and they're not too far from the original, are they?

@jbrooksuk
Copy link
Owner

@hussani any further decisions on this?

@hussani
Copy link
Collaborator Author

hussani commented Sep 13, 2013

Oh, God!
I'm sorry for late answer.

Do you can merge my modifications?

I will sync my repo with your, after it, i will create a other fork with my personal changes ( the colors basically).
Any feature change, i commit in your fork.

Sound good for you?

For me appear the most practice solution.

@jbrooksuk
Copy link
Owner

I've merged everything that your fork and others had added.

What we could do is use my repo as the main source for Oblivion, then include several variations, like "Oblivion Light" or whatever, that way you still get your own colour scheme and it originates from the main source of Oblivion.

I can add you as a developer on this repository, then you can add your variation to it. We'll change Package Control afterwards. How does that sound?

@hussani
Copy link
Collaborator Author

hussani commented Sep 16, 2013

Nice!

Is time to change the Package Control repositories.json and create another repo for my personal changes.
Give me 2 days to sync repos and open a PR on Package Control changing Oblivion to your repo and adding my new repo.

@jbrooksuk
Copy link
Owner

Okay, you're now a collaborator. When you push your changes, put them into a new file 😄

@hussani
Copy link
Collaborator Author

hussani commented Sep 16, 2013

Thanks for all!
=D

@jbrooksuk
Copy link
Owner

@hussani, once your customised version is in the repository, we can go about changing Package Control so that your version is automatically installed through this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants