Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom error types when handling errors #57

Open
jbmusso opened this issue Dec 10, 2014 · 0 comments
Open

Add custom error types when handling errors #57

jbmusso opened this issue Dec 10, 2014 · 0 comments
Labels
enhancement

Comments

@jbmusso
Copy link
Owner

jbmusso commented Dec 10, 2014

Consider passing custom/explicit error types to the callback when errors occur.

I can think of these errors right now:

  • NetworkError Ex: no internet connection, should be easy to catch at the http module level
  • ServerError Ex: Rexster returns with a 500 error for some reasons (the HTTP code should be explicitely returned as well).
  • TimeoutError Ex: connected, but script timed out for various reasons (connection timeout? script timeout?)
  • ScriptError Ex: exception thrown by Rexster when executing the script.

There could be more (or less) errors. Maybe ConnectionError and ClientError. Thoughts welcomed!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbmusso