Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify/reformat source with some sane formatting #1902

Open
cstamas opened this issue Jan 10, 2025 · 4 comments
Open

Modify/reformat source with some sane formatting #1902

cstamas opened this issue Jan 10, 2025 · 4 comments
Labels
ideas Some idea/suggestion around jbang behavior/feature set

Comments

@cstamas
Copy link
Contributor

cstamas commented Jan 10, 2025

Is your feature request related to a problem? Please describe.
I'm always frustrated when looking at the code 😄

Describe the solution you'd like
Apply some "normal" code formatting, as this (failed by spotless and then "reformatted" by spotless) is insane:
d33f99d

Describe alternatives you've considered
Some modern and normal formatting, as 80 width is long past current screen estates.

Additional context
This formatting
d33f99d

vs this one (both are quite "fluent"):
https://github.com/apache/maven/blob/master/impl/maven-core/src/main/java/org/apache/maven/internal/impl/DefaultLifecycleRegistry.java

@cstamas cstamas added the ideas Some idea/suggestion around jbang behavior/feature set label Jan 10, 2025
@quintesse
Copy link
Contributor

I agree, in general I never liked the fact that it will indent continued lines past the end of the first line. It pushes some lines way off to the right. I hope it's fixable, the Google format is notoriously difficult to configure IIRC.

@cstamas
Copy link
Contributor Author

cstamas commented Jan 11, 2025

JBang uses Eclipse formatter as I see, at least spotless config points at misc/eclipse_something.xml

@quintesse
Copy link
Contributor

In that case 👍

@maxandersen
Copy link
Collaborator

its 5 years since I last edited the formatting rules...I'm used to it now so I just edit code and let the formatter apply L)

but PRs welcome assume it makes things better and doesn't reformat the world completely :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ideas Some idea/suggestion around jbang behavior/feature set
Projects
None yet
Development

No branches or pull requests

3 participants