Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One particular Italian translation is plain wrong #498

Open
lelit opened this issue Aug 20, 2024 · 9 comments · May be fixed by #499
Open

One particular Italian translation is plain wrong #498

lelit opened this issue Aug 20, 2024 · 9 comments · May be fixed by #499

Comments

@lelit
Copy link

lelit commented Aug 20, 2024

The Italian catalog contains a translation for the very common word Content as Soddisfare (that means Satisfy in English).

This causes a WTF moment when you look at many Wagtail admin forms, because the default edit_handler uses heading=gettext_lazy("Content").

@MrCordeiro
Copy link
Contributor

Thanks for the heads-up @lelit

I'm not an Italian speaker myself but, if you are, would you be willing to create a PR?

@lelit
Copy link
Author

lelit commented Aug 21, 2024

I wonder if it would be better to just drop that, given that it already comes from the Wagtail catalog.
What do you think?

@MrCordeiro
Copy link
Contributor

MrCordeiro commented Aug 24, 2024

True, but because it's a term that also appears on Wagtailsmenus, even if we delete it, the prompt to update the translation will show up again as soon as someone tries to update it.

@MrCordeiro MrCordeiro linked a pull request Aug 24, 2024 that will close this issue
@MrCordeiro
Copy link
Contributor

@lelit, #499 should fix that. Could you check if the new translation is correct /if there are other translation errors worth fixing in that PR?

I also took the chance to run makemessages to update the localization descriptions. This is why the PR contains so many modified files.

@lelit
Copy link
Author

lelit commented Aug 26, 2024

Sure, I will try to review the (Italian) changes looking at "final" sources, because doing that on PO diffs is harder.

@lelit
Copy link
Author

lelit commented Aug 26, 2024

I reviewed the changes in #499, and I'd suggest these further changes:

diff --git a/wagtailmenus/locale/it/LC_MESSAGES/django.po b/wagtailmenus/locale/it/LC_MESSAGES/django.po
index 0ba4be4..fd613ba 100644
--- a/wagtailmenus/locale/it/LC_MESSAGES/django.po
+++ b/wagtailmenus/locale/it/LC_MESSAGES/django.po
@@ -13,7 +13,7 @@ msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
 "POT-Creation-Date: 2024-08-24 21:55+0100\n"
-"PO-Revision-Date: 2017-03-20 23:04+0000\n"
+"PO-Revision-Date: 2024-08-26 09:53+0200\n"
 "Last-Translator: Andy Babic, 2018\n"
 "Language-Team: Italian (https://www.transifex.com/rkhleics/teams/73023/it/)\n"
 "Language: it\n"
@@ -39,10 +39,8 @@ msgid "4: Allow 3 levels of sub-navigation"
 msgstr "4: Fino a 3 livelli di sottomenù"
 
 #: wagtailmenus/copyable_snippetviewset.py:17
-#, fuzzy
-#| msgid "The menu could not be saved due to errors."
 msgid "The snippet could not be copied due to errors."
-msgstr "Non è stato possibile salvare il menù a seguito di errori."
+msgstr "Non è stato possibile salvare lo snippet a seguito di errori."
 
 #: wagtailmenus/copyable_snippetviewset.py:38
 msgid "Copy"
@@ -55,7 +53,7 @@ msgstr ""
 
 #: wagtailmenus/forms.py:26
 msgid "By default, this will be used as the link text when appearing in menus."
-msgstr "Questo è il testo di collegamento predefinito usato nei menu."
+msgstr "Questo è il testo di collegamento predefinito usato nei menù."
 
 #: wagtailmenus/menuadmin.py:82
 msgid "Main menu"
@@ -75,20 +73,16 @@ msgid "Settings"
 msgstr "Impostazioni"
 
 #: wagtailmenus/menuadmin.py:127
-#, fuzzy
-#| msgid "The menu could not be saved due to errors."
 msgid "The flat menu could not be saved due to errors"
-msgstr "Non è stato possibile salvare il menù a seguito di errori."
+msgstr "Non è stato possibile salvare il menù piatto a seguito di errori."
 
 #: wagtailmenus/menuadmin.py:132
 msgid "Flat menus"
 msgstr "Menù piatti"
 
 #: wagtailmenus/menuadmin.py:144
-#, fuzzy
-#| msgid "The menu could not be saved due to errors."
 msgid "The flat menu could not be saved due to errors."
-msgstr "Non è stato possibile salvare il menù a seguito di errori."
+msgstr "Non è stato possibile salvare il menù piatto a seguito di errori."
 
 #: wagtailmenus/models/menuitems.py:32 wagtailmenus/models/pages.py:140
 msgid "link to an internal page"
@@ -100,7 +94,7 @@ msgstr "link a URL specifico"
 
 #: wagtailmenus/models/menuitems.py:44 wagtailmenus/models/pages.py:153
 msgid "append to URL"
-msgstr "aggiunti all'URL"
+msgstr "aggiungi all'URL"
 
 #: wagtailmenus/models/menuitems.py:48
 msgid ""
@@ -119,8 +113,8 @@ msgid ""
 "Use this field to optionally specify an additional value for each menu item, "
 "which you can then reference in custom menu templates."
 msgstr ""
-"Opzionalmente usa questo campo per specificare, per ogni voce di menù, un "
-"valore addizionale che può essere poi referenziato in un template di menù "
+"Usa questo campo per specificare, per ogni voce di menù, un valore "
+"addizionale che può essere poi referenziato in un template di menù "
 "personalizzato."
 
 #: wagtailmenus/models/menuitems.py:63
@@ -145,7 +139,7 @@ msgstr "voci menù"
 
 #: wagtailmenus/models/menuitems.py:113 wagtailmenus/models/pages.py:207
 msgid "Please choose an internal page or provide a custom URL"
-msgstr "Scegliere una pagina interna o definire un URL specifico"
+msgstr "Scegli una pagina interna o definisci un URL specifico"
 
 #: wagtailmenus/models/menuitems.py:116 wagtailmenus/models/pages.py:212
 msgid "Linking to both a page and custom URL is not permitted"
@@ -201,7 +195,7 @@ msgstr "titolo"
 
 #: wagtailmenus/models/menus.py:1148
 msgid "For internal reference only."
-msgstr "Solamente per utilizzo interno"
+msgstr "Solo per riferimento interno."
 
 #: wagtailmenus/models/menus.py:1154
 msgid ""
@@ -217,7 +211,7 @@ msgstr "intestazione"
 
 #: wagtailmenus/models/menus.py:1162
 msgid "If supplied, appears above the menu when rendered."
-msgstr "Se valorizzato, appare sopra il menù quando disegnato."
+msgstr "Se specificato, appare sopra il menù quando disegnato."
 
 #: wagtailmenus/models/menus.py:1169
 msgid ""
@@ -240,7 +234,7 @@ msgstr "menù piatti"
 
 #: wagtailmenus/models/menus.py:1189
 msgid "no. of items"
-msgstr "N. di voci"
+msgstr "N° di voci"
 
 #: wagtailmenus/models/pages.py:17
 msgid "repeat in sub-navigation"
@@ -252,8 +246,8 @@ msgid ""
 "children when displaying a sub-navigation for this page."
 msgstr ""
 "Se selezionato, un link a questa stessa pagina verrà mostrato insieme alle "
-"voci di menù dei diretti figli quando visualizzato un sottomenù per questa "
-"pagina"
+"voci di menù dei diretti figli quando viene visualizzato un sottomenù per "
+"questa pagina."
 
 #: wagtailmenus/models/pages.py:25
 msgid "repeated item link text"
@@ -285,9 +279,7 @@ msgstr ""
 
 #: wagtailmenus/models/pages.py:201
 msgid "A link page cannot link to another link page"
-msgstr ""
-"Un collegamento di pagina non può referenziare un altro collegamento di "
-"pagina."
+msgstr "Un collegamento di pagina non può referenziare un altro collegamento di pagina."
 
 #: wagtailmenus/models/pages.py:289 wagtailmenus/models/pages.py:299
 #, python-format
@@ -323,7 +315,7 @@ msgstr "Modifica %(snippet_type_name)s - %(object)s"
 #: wagtailmenus/templates/wagtailmenus/mainmenu_edit.html:19
 #: wagtailmenus/templates/wagtailsnippets/snippets/copy.html:19
 msgid "Actions"
-msgstr ""
+msgstr "Azioni"
 
 #: wagtailmenus/templates/wagtailsnippets/snippets/copy.html:3
 #, python-format

They mainly fall into these categories:

  • remove fuzzy entries, related to menu -> flat menu or menu -> snippet
  • consistently use the accented form menù
  • consistently use the direct form Scegli ... instead of Scegliere ...
  • add some missing trailing fullstop, when present in the original
  • prefer to N. to translate no. of items
  • translate Actions

I'm willing to open a PR, should you prefer so, let me know.

@MrCordeiro
Copy link
Contributor

@lelit , sorry for the delay!

I'm okay with making the changes; it may take a while as my life is hectic right now. Please feel free to open a PR if you'd like to move faster.

@lelit
Copy link
Author

lelit commented Sep 4, 2024

No problem at all! I won't be able to that until second half of September, due to a short deserved vacation, but then I'll happily open a PR, if this is still pending. In that case, please tell me if I should build that on top of #499 or what.

@MrCordeiro
Copy link
Contributor

Yes, please build it on top of #499 as it also contains updates on the other po files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants