Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbundle all dependencies. #273

Open
kennethreitz opened this issue Jan 25, 2017 · 6 comments
Open

Unbundle all dependencies. #273

kennethreitz opened this issue Jan 25, 2017 · 6 comments

Comments

@kennethreitz
Copy link
Contributor

It's time.

@iurisilvio
Copy link
Collaborator

I agree! But why you closed the issue?

@kennethreitz kennethreitz reopened this Feb 5, 2017
@kennethreitz
Copy link
Contributor Author

@MorleyB might take a crack at this!

@hermanocabral
Copy link

please!

@kennethreitz
Copy link
Contributor Author

@MorleyB need any help getting started?

claudep added a commit to claudep/tablib that referenced this issue Feb 20, 2017
claudep added a commit to claudep/tablib that referenced this issue Feb 21, 2017
claudep added a commit to claudep/tablib that referenced this issue Feb 21, 2017
claudep added a commit to claudep/tablib that referenced this issue Feb 24, 2017
claudep added a commit to claudep/tablib that referenced this issue Feb 24, 2017
claudep added a commit to claudep/tablib that referenced this issue Mar 9, 2019
claudep added a commit to claudep/tablib that referenced this issue Mar 9, 2019
claudep added a commit to claudep/tablib that referenced this issue Mar 9, 2019
claudep added a commit to claudep/tablib that referenced this issue Mar 9, 2019
claudep added a commit to claudep/tablib that referenced this issue Mar 10, 2019
@jayvdb
Copy link
Member

jayvdb commented Mar 12, 2019

De-vendoring dbfpy is going to be a bit more effort than the others.

The dbfpy package on PyPi is 2.3.1 , and the bundled version here is from an older release, 2.2.5, and it is slightly patched, and the tests here fail when using the latest PyPI package - the struct's are different.

The errors can be encountered with jayvdb@95cfef3, and viewed at https://travis-ci.org/jayvdb/tablib/jobs/505156956

The adaptions are not visible in git, but there is a bit of history at https://github.com/kennethreitz/tablib/pull/153 , and a bit more at https://github.com/phargogh/dbfpy3/commits/master

@phargogh might be able to help.

The diff which makes the tablib tests pass is

--- dbfpy-2.3.1/dbfpy/fields.py.orig    2019-03-12 16:16:12.434154549 +0700
+++ dbfpy-2.3.1/dbfpy/fields.py 2019-03-12 16:33:19.785761986 +0700
@@ -150,7 +150,7 @@
         return (
             _name +
             self.typeCode +
-            struct.pack("<L", self.start) +
+            chr(0) * 4 +
             chr(self.length) +
             chr(self.decimalCount) +
             chr(0) * 14

But I suspect that correct answer will be a more complicated mixture of the two codebases, as both have had bug fixes, and dbf comes in several flavours.

A few days ago I found another version of the codebase on GitHub, and asked if they are interested in releasing a new package at antmoth/dbfpy#1 , and @estelendur is interested.

@jayvdb
Copy link
Member

jayvdb commented Mar 12, 2019

Another approach is to switch to using a different library, such as pypi packages dbfread or dbf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants