From 0347d0ec89bd889756ffcf8e8f6d4b7623530263 Mon Sep 17 00:00:00 2001 From: jay-hodgson Date: Fri, 13 Sep 2024 16:00:54 -0700 Subject: [PATCH] what if we do not look for a button for home? --- apps/portals-e2e/src/configs/routesConfig.ts | 15 ++++++-- .../src/config/routesConfig.ts | 38 +++++++++---------- apps/portals/genie/src/config/routesConfig.ts | 38 +++++++++---------- 3 files changed, 49 insertions(+), 42 deletions(-) diff --git a/apps/portals-e2e/src/configs/routesConfig.ts b/apps/portals-e2e/src/configs/routesConfig.ts index dff9af9229..c47f82da7b 100644 --- a/apps/portals-e2e/src/configs/routesConfig.ts +++ b/apps/portals-e2e/src/configs/routesConfig.ts @@ -17,8 +17,15 @@ type RouteConfig = Record // lists each Portal's navigation buttons and links const routesConfig: RouteConfig = { adknowledgeportal: { - buttons: ['Home', 'Explore', 'Sign In'], - links: ['Analysis Platforms', 'Data Access', 'Contribute', 'News', 'Help'], + buttons: ['Explore', 'Sign In'], + links: [ + 'Home', + 'Analysis Platforms', + 'Data Access', + 'Contribute', + 'News', + 'Help', + ], }, arkportal: { buttons: ['Explore', 'Sign In'], @@ -64,8 +71,8 @@ const routesConfig: RouteConfig = { links: ['Home', 'Apply'], }, genie: { - buttons: ['Home', 'Explore', 'Sign In'], - links: ['Data Releases', 'Access', 'Help'], + buttons: ['Explore', 'Sign In'], + links: ['Home', 'Data Releases', 'Access', 'Help'], }, } diff --git a/apps/portals/adknowledgeportal/src/config/routesConfig.ts b/apps/portals/adknowledgeportal/src/config/routesConfig.ts index 346d1c9d34..a34e98ff53 100644 --- a/apps/portals/adknowledgeportal/src/config/routesConfig.ts +++ b/apps/portals/adknowledgeportal/src/config/routesConfig.ts @@ -23,6 +23,25 @@ import { import { ColumnSingleValueFilterOperator } from '@sage-bionetworks/synapse-types' const routes: GenericRoute[] = [ + { + path: '', + exact: false, + synapseConfigArray: [ + { + name: 'SurveyToast', + props: { + localStorageKey: + 'org.sagebionetworks.security.cookies.portal.adkpsurvey.dismissed', + title: + 'What Metrics Matter to You? Help Us Improve the AD Knowledge Portal!', + description: + 'Take our quick survey and share your feedback to make the portal even better. Your input will directly impact the data and insights we provide.', + surveyURL: + 'https://docs.google.com/forms/d/e/1FAIpQLScpWL2N3LGQlNcqKRXQ-qST-UPKngutNkvbhPVkozD7cQR8-g/viewform', + }, + }, + ], + }, { path: '', hideRouteFromNavbar: true, @@ -196,25 +215,6 @@ const routes: GenericRoute[] = [ }, ], }, - { - path: '', - exact: false, - synapseConfigArray: [ - { - name: 'SurveyToast', - props: { - localStorageKey: - 'org.sagebionetworks.security.cookies.portal.adkpsurvey.dismissed', - title: - 'What Metrics Matter to You? Help Us Improve the AD Knowledge Portal!', - description: - 'Take our quick survey and share your feedback to make the portal even better. Your input will directly impact the data and insights we provide.', - surveyURL: - 'https://docs.google.com/forms/d/e/1FAIpQLScpWL2N3LGQlNcqKRXQ-qST-UPKngutNkvbhPVkozD7cQR8-g/viewform', - }, - }, - ], - }, { // PORTALS-2028: redirect /ExperimentalModels to /Explore/Experimental%20Models exact: true, diff --git a/apps/portals/genie/src/config/routesConfig.ts b/apps/portals/genie/src/config/routesConfig.ts index 5b37c00288..1fc9f2e805 100644 --- a/apps/portals/genie/src/config/routesConfig.ts +++ b/apps/portals/genie/src/config/routesConfig.ts @@ -4,6 +4,25 @@ import { dataReleases } from './synapseConfigs' import { currentDataReleases } from './synapseConfigs/dataReleases' const routes: GenericRoute[] = [ + { + path: '', + exact: false, + synapseConfigArray: [ + { + name: 'SurveyToast', + props: { + localStorageKey: + 'org.sagebionetworks.security.cookies.portal.geniesurvey.dismissed', + title: + 'What Metrics Matter to You? Help Us Improve the GENIE Portal!', + description: + 'Take our quick survey and share your feedback to make the portal even better. Your input will directly impact the data and insights we provide.', + surveyURL: + 'https://docs.google.com/forms/d/e/1FAIpQLSe6V_b-n8pVGjZEvjv4tBklFwRPzeOMvjGzOzURWLFyvOq4fw/viewform', + }, + }, + ], + }, { path: '', exact: true, @@ -48,25 +67,6 @@ const routes: GenericRoute[] = [ }, ], }, - { - path: '', - exact: false, - synapseConfigArray: [ - { - name: 'SurveyToast', - props: { - localStorageKey: - 'org.sagebionetworks.security.cookies.portal.geniesurvey.dismissed', - title: - 'What Metrics Matter to You? Help Us Improve the GENIE Portal!', - description: - 'Take our quick survey and share your feedback to make the portal even better. Your input will directly impact the data and insights we provide.', - surveyURL: - 'https://docs.google.com/forms/d/e/1FAIpQLSe6V_b-n8pVGjZEvjv4tBklFwRPzeOMvjGzOzURWLFyvOq4fw/viewform', - }, - }, - ], - }, { path: 'Explore', routes: [