Skip to content

Commit

Permalink
what if we do not look for a button for home?
Browse files Browse the repository at this point in the history
  • Loading branch information
jay-hodgson committed Sep 13, 2024
1 parent 0730092 commit 0347d0e
Show file tree
Hide file tree
Showing 3 changed files with 49 additions and 42 deletions.
15 changes: 11 additions & 4 deletions apps/portals-e2e/src/configs/routesConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,15 @@ type RouteConfig = Record<Portal, RouteButtonsLinks>
// lists each Portal's navigation buttons and links
const routesConfig: RouteConfig = {
adknowledgeportal: {
buttons: ['Home', 'Explore', 'Sign In'],
links: ['Analysis Platforms', 'Data Access', 'Contribute', 'News', 'Help'],
buttons: ['Explore', 'Sign In'],
links: [
'Home',
'Analysis Platforms',
'Data Access',
'Contribute',
'News',
'Help',
],
},
arkportal: {
buttons: ['Explore', 'Sign In'],
Expand Down Expand Up @@ -64,8 +71,8 @@ const routesConfig: RouteConfig = {
links: ['Home', 'Apply'],
},
genie: {
buttons: ['Home', 'Explore', 'Sign In'],
links: ['Data Releases', 'Access', 'Help'],
buttons: ['Explore', 'Sign In'],
links: ['Home', 'Data Releases', 'Access', 'Help'],
},
}

Expand Down
38 changes: 19 additions & 19 deletions apps/portals/adknowledgeportal/src/config/routesConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,25 @@ import {
import { ColumnSingleValueFilterOperator } from '@sage-bionetworks/synapse-types'

const routes: GenericRoute[] = [
{
path: '',
exact: false,
synapseConfigArray: [
{
name: 'SurveyToast',
props: {
localStorageKey:
'org.sagebionetworks.security.cookies.portal.adkpsurvey.dismissed',
title:
'What Metrics Matter to You? Help Us Improve the AD Knowledge Portal!',
description:
'Take our quick survey and share your feedback to make the portal even better. Your input will directly impact the data and insights we provide.',
surveyURL:
'https://docs.google.com/forms/d/e/1FAIpQLScpWL2N3LGQlNcqKRXQ-qST-UPKngutNkvbhPVkozD7cQR8-g/viewform',
},
},
],
},
{
path: '',
hideRouteFromNavbar: true,
Expand Down Expand Up @@ -196,25 +215,6 @@ const routes: GenericRoute[] = [
},
],
},
{
path: '',
exact: false,
synapseConfigArray: [
{
name: 'SurveyToast',
props: {
localStorageKey:
'org.sagebionetworks.security.cookies.portal.adkpsurvey.dismissed',
title:
'What Metrics Matter to You? Help Us Improve the AD Knowledge Portal!',
description:
'Take our quick survey and share your feedback to make the portal even better. Your input will directly impact the data and insights we provide.',
surveyURL:
'https://docs.google.com/forms/d/e/1FAIpQLScpWL2N3LGQlNcqKRXQ-qST-UPKngutNkvbhPVkozD7cQR8-g/viewform',
},
},
],
},
{
// PORTALS-2028: redirect /ExperimentalModels to /Explore/Experimental%20Models
exact: true,
Expand Down
38 changes: 19 additions & 19 deletions apps/portals/genie/src/config/routesConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,25 @@ import { dataReleases } from './synapseConfigs'
import { currentDataReleases } from './synapseConfigs/dataReleases'

const routes: GenericRoute[] = [
{
path: '',
exact: false,
synapseConfigArray: [
{
name: 'SurveyToast',
props: {
localStorageKey:
'org.sagebionetworks.security.cookies.portal.geniesurvey.dismissed',
title:
'What Metrics Matter to You? Help Us Improve the GENIE Portal!',
description:
'Take our quick survey and share your feedback to make the portal even better. Your input will directly impact the data and insights we provide.',
surveyURL:
'https://docs.google.com/forms/d/e/1FAIpQLSe6V_b-n8pVGjZEvjv4tBklFwRPzeOMvjGzOzURWLFyvOq4fw/viewform',
},
},
],
},
{
path: '',
exact: true,
Expand Down Expand Up @@ -48,25 +67,6 @@ const routes: GenericRoute[] = [
},
],
},
{
path: '',
exact: false,
synapseConfigArray: [
{
name: 'SurveyToast',
props: {
localStorageKey:
'org.sagebionetworks.security.cookies.portal.geniesurvey.dismissed',
title:
'What Metrics Matter to You? Help Us Improve the GENIE Portal!',
description:
'Take our quick survey and share your feedback to make the portal even better. Your input will directly impact the data and insights we provide.',
surveyURL:
'https://docs.google.com/forms/d/e/1FAIpQLSe6V_b-n8pVGjZEvjv4tBklFwRPzeOMvjGzOzURWLFyvOq4fw/viewform',
},
},
],
},
{
path: 'Explore',
routes: [
Expand Down

0 comments on commit 0347d0e

Please sign in to comment.