Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jax.scipy.spatial.transform.Rotation.from_quat is missing scalar_first flag #25491

Open
adam-hartshorne opened this issue Dec 14, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@adam-hartshorne
Copy link

adam-hartshorne commented Dec 14, 2024

Description

The Rotation package of methods is supposed to mimic the scipy package. However the from_quat() method is missing the scalar_first flag. The as_quat() has it.

It also isn't clear from the documtation if the quaternion expected for this function is [x,y,z,w] or [w,x,y,z]

Edit:- It looks like it was committed to the main branch in September but now isn't there,

2ff26ff

System info (python version, jaxlib version, accelerator, etc.)

N/A

@adam-hartshorne adam-hartshorne added the bug Something isn't working label Dec 14, 2024
@jakevdp
Copy link
Collaborator

jakevdp commented Dec 16, 2024

Hi - thanks for the report! jax.scipy.spatial.transform.Rotation is not under active development, and will be removed as soon as there is a viable alternative (refer to https://jax.readthedocs.io/en/latest/jep/18137-numpy-scipy-scope.html#scipy-spatial for a discussion of this).

That said, we will accept PRs making small changes and/or bug fixes if you're interested in adding support for this keyword.

@jakevdp jakevdp self-assigned this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants