Skip to content

Commit ecd61a1

Browse files
fix for service semver dropdown
1 parent 65ce225 commit ecd61a1

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

layouts/partials/sidebar.pug

+7-7
Original file line numberDiff line numberDiff line change
@@ -3,29 +3,29 @@
33
- var items = hierarchy
44
- var service = null
55
- var versionTitle = ''
6-
- var semanticVersion = /^[0-9]+\.[0-9]+/
7-
- var semanticVersionService = /^v[0-9]+/
6+
- var semver = /^[0-9]+\.[0-9]+/
7+
- var semverService = /^(v|)[0-9](.*)/
88
- var dropdown = []
99

1010
// Service Docs
1111
if paths[0] === 'services' && paths[1]
1212
- items = hierarchy.findByPath('/' + paths[0] + '/' + paths[1])
13-
- var servicesDropdown = items.children.filter(x => x.id.startsWith('v'))
13+
- var servicesDropdown = items.children.filter(x => semverService.test(x.id))
1414
- dropdown = servicesDropdown
1515
- service = hierarchy.findByPath('/' + paths[0] + '/' + paths[1])
16-
if paths[2] && paths[2].startsWith('v')
16+
if paths[2] && semverService.test(paths[2])
1717
- versionTitle = paths[2]
1818
- items = hierarchy.findByPath('/' + paths[0] + '/' + paths[1] + '/' + paths[2])
1919

2020
// DC/OS Docs
21-
if semanticVersion.test(paths[0])
22-
- dropdown = hierarchy.children.filter(item => semanticVersion.test(item.id))
21+
if semver.test(paths[0])
22+
- dropdown = hierarchy.children.filter(item => semver.test(item.id))
2323
- items = hierarchy.findByPath('/' + paths[0])
2424
- versionTitle = paths[0]
2525

2626
mixin renderSidebarHeader()
2727
- var showDropdown = true
28-
if !dropdown.length || (dropdown.length == 1 && semanticVersionService.test(dropdown[0].id))
28+
if !dropdown.length || (dropdown.length == 1 && semverService.test(dropdown[0].id))
2929
- showDropdown = false
3030
header(class='sidebar__header')
3131
div(class='sidebar__dropdown')

layouts/service-docs-landing.pug

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,15 @@
22
- var currentPath = '/' + path
33
- var items = hierarchy.children.find(child => child.id === paths[0])
44
- var headerItems = hierarchy.find('menus').filter(page => page.menus.indexOf('header') != -1)
5+
- var semverService = /^(v|)[0-9](.*)/
56

67
mixin renderGridToc()
78
div(class='grid-toc')
89
each val, index in items.children
910
if val.menuWeight != -1
1011
if val.children
1112
each childVal, childIndex in val.children
12-
if /^v[0-9]+/.test(childVal.id)
13+
if semverService.test(childVal.id)
1314
- versioned = true
1415
- childVal.title = val.title
1516
- val = childVal

plugins/metalsmith-algolia.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,10 @@ const buildSemverMap = (files) => {
153153
// Filter
154154
for(let file in files) {
155155
const pathParts = file.split('/');
156-
if(pathParts[0] == 'services' && pathParts[2] && /v[0-9].[0-9](.*)/.test(pathParts[2]) && versions.indexOf(pathParts[2]) == -1) {
156+
if(pathParts[0] == 'services' && pathParts[2] && /^(v|)[0-9].[0-9](.*)/.test(pathParts[2]) && versions.indexOf(pathParts[2]) == -1) {
157157
versions.push(pathParts[2]);
158158
}
159-
else if (/[0-9]\.[0-9](.*)/.test(pathParts[0]) && versions.indexOf(pathParts[0]) == -1) {
159+
else if (/^[0-9]\.[0-9](.*)/.test(pathParts[0]) && versions.indexOf(pathParts[0]) == -1) {
160160
versions.push(pathParts[0]);
161161
}
162162
}
@@ -206,7 +206,7 @@ const getSharedAttributes = (fileData, hierarchy, semverMap) => {
206206
}
207207
// If in /services/product/version/**
208208
if (pathParts[2]) {
209-
let regex = /v[0-9].[0-9](.*)/g;
209+
let regex = /^(v|)[0-9].[0-9](.*)/g;
210210
let isVersion = regex.test(pathParts[2]);
211211
if (isVersion) {
212212
record.version = product + ' ' + pathParts[2].substr(1);
@@ -217,7 +217,7 @@ const getSharedAttributes = (fileData, hierarchy, semverMap) => {
217217
}
218218

219219
// Docs version
220-
else if (/[0-9]\.[0-9](.*)/.test(pathParts[0])) {
220+
else if (/^[0-9]\.[0-9](.*)/.test(pathParts[0])) {
221221
product = 'DC/OS';
222222
record.section = 'DC/OS Docs';
223223
record.product = product;

scripts/reduce-pages.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ rm -rf ./pages/1.10/!(index.md)
1111
rm -rf ./pages/1.9/!(index.md)
1212
rm -rf ./pages/1.8/!(index.md)
1313
rm -rf ./pages/1.7/!(index.md)
14-
rm -rf ./pages/services/!(index.md|beta-cassandra|jenkins)
14+
rm -rf ./pages/services/!(index.md|cassandra|jenkins)

0 commit comments

Comments
 (0)