Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If MergeBot times out waiting for a Jenkins job it may start another merge after timing without cancelling the job. #23

Open
jasonkuster opened this issue Jul 19, 2017 · 0 comments

Comments

@jasonkuster
Copy link
Owner

jasonkuster commented Jul 19, 2017

It doesn't seem likely that MergeBot will be able to cancel the job (investigate if we can get a key from Infra anyway) but in this case we should really capture the SHA of the latest commit and ensure that it and the commit Jenkins are testing are the same. Jenkins code should probably be updated to handle this contingency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant