Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angle fitlering looks funny #4

Open
contradict opened this issue Feb 25, 2018 · 1 comment
Open

Angle fitlering looks funny #4

contradict opened this issue Feb 25, 2018 · 1 comment

Comments

@contradict
Copy link
Collaborator

At sensors.cpp, line 72, probably meant abs_angle_traversed.

Test this once we have the machine re-assembled.

@contradict
Copy link
Collaborator Author

I have decided not to fix this. I think it really is broken, but the implications of fixing it are unclear and difficult to test. The correct thing to do is re-write this whole module to use interrupt driven sampling with a simpler filter and perhaps a rolling min/max buffer. It seems to work, not a big deal right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant