Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview-tui: image preview with libsixel not working for some images #1966

Closed
6 of 9 tasks
Giessen opened this issue Dec 7, 2024 · 4 comments
Closed
6 of 9 tasks

Comments

@Giessen
Copy link

Giessen commented Dec 7, 2024

Environment details

  • Operating System: wsl2
  • Desktop Environment:
  • Terminal Emulator: Windows Terminal (preview v1.22.3232.0)
  • Shell: ZSH
  • Custom desktop opener (if applicable):
  • Program options used: NNN_PREVIEWIMGPROG='img2sixel' NNN_PLUG='i:preview-tui' nnn -a -i -Pi
  • Configuration options set:
  • Plugins are installed: preview-tui
  • Issue exists on nnn master

Exact steps to reproduce the issue

1.install libsixel
sudo apt-get install libsixel-bin
2.test libsixel
img2sixel -g bird.jpg => ok
img2sixel -g voyage.jpeg => ok
3.compile tmux (v next-3.6) with sixel support and install
git clone https://github.com/tmux/tmux.git
cd tmux
sh autogen.sh
./configure --enable-sixel
make
sudo make install
3.run nnn, open preview-tui pane, navigate to the testing images (bird.jpg, voyage.jpeg, attached bellow)
bird.jpg is ok.
voyage.jpeg shows nothing!!!

Any ideas, please? Thanks a lot.

@Giessen Giessen added the bug label Dec 7, 2024
@Giessen Giessen changed the title preview-tui: img preview with libsixel not working for some images preview-tui: image preview with libsixel not working for some images Dec 7, 2024
@Giessen
Copy link
Author

Giessen commented Dec 7, 2024

testing images.zip

@N-R-K
Copy link
Collaborator

N-R-K commented Jan 6, 2025

2.test libsixel
img2sixel -g bird.jpg => ok
img2sixel -g voyage.jpeg => ok

Did you test this within tmux or without?

@j4james
Copy link

j4james commented Jan 11, 2025

By default tmux has a maximum image size of 1 MB (see tmux/tmux#3726), and voyage.jpeg is close to 4 MB once you convert it to sixel. The good news, though, is that tmux recently added an option for changing that limit if you want to make it higher. I don't think that option is included in the current release, but you could always build it yourself if you're desperate.

@N-R-K N-R-K added environment and removed bug labels Jan 11, 2025
@N-R-K
Copy link
Collaborator

N-R-K commented Jan 11, 2025

If it's an issue with tmux, then there's nothing to do on our end. Closing.

@N-R-K N-R-K closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants