Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting to Atom generates an HTML file #813

Open
sjehuda opened this issue Jan 9, 2025 · 3 comments
Open

Exporting to Atom generates an HTML file #813

sjehuda opened this issue Jan 9, 2025 · 3 comments

Comments

@sjehuda
Copy link
Contributor

sjehuda commented Jan 9, 2025

Bug reports

Good (Syndication XML)

buku -t instance:peertube -e list_of_peertube_instances.rss

Bad (HTML)

buku -t instance:peertube -e list_of_peertube_instances.atom

The expected result for .atom should be the same (i.e. XML syndication feed), not HTML.

@LeXofLeviafan
Copy link
Collaborator

Not a bug: this extension is not listed as supported in the first place.

I suppose you can change this into a feature request ("Support .atom as export extension"), and/or implement it yourself (just make sure to update all docs accordingly).

@sjehuda
Copy link
Contributor Author

sjehuda commented Jan 9, 2025

I know, that it is not an actual "bug".

And I know it requires only adding "atom"" to the list of selection of file extensions.

Since I do not know what could be the best practice, I have decided to make this report.

I assume that this statement elif export_type in ('atom', 'rss'): should be fine.

And also assert export_type in ['markdown', 'html', 'org', 'xbel', 'atom', 'rss'].

@LeXofLeviafan
Copy link
Collaborator

Since I do not know what could be the best practice, I have decided to make this report.

A feature request should be presented as such, not as a bug report.

I assume that this statement elif export_type in ('atom', 'rss'): should be fine.
And also assert export_type in ['markdown', 'html', 'org', 'xbel', 'atom', 'rss'].

"Export type" means format, not the file extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants