Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full license text in JSON report #222

Open
sebastianludwig opened this issue Aug 9, 2022 · 5 comments
Open

Full license text in JSON report #222

sebastianludwig opened this issue Aug 9, 2022 · 5 comments

Comments

@sebastianludwig
Copy link

Currently only the HTML report contains the full license text. We'd love to use your plugin but we need the full license text in the JSON report. Would you be open to a PR?

@jaredsburrows
Copy link
Owner

Yes. I am always willing to accept PRs!. Can we add this new functionality while keeping the old functionality?

@sebastianludwig
Copy link
Author

Hey, sure, we can just add a new config value. A slight problem is that the defaults currently vary between JSON (not included) and HTML (included). Would it be okay with you to change the default of either one of them? Then we could have a config value like includeFullLicenseTexts = true/false which does the same for all reports. If yes, what should be the default value? true?

@jaredsburrows
Copy link
Owner

Yeah. Should be true.

@jaredsburrows
Copy link
Owner

@sebastianludwig Do you mind sending a PR for this?

@sebastianludwig
Copy link
Author

Hey, I moved projects and am currently not working with Android. If that changes in the future, I'll happily come back to my offer. Sorry for not getting back to you any earlier and for not being able to help :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants