From b6bd1ee2bcbfb1bbfa0b20eb9926f48bc38e34be Mon Sep 17 00:00:00 2001 From: swyx Date: Wed, 8 Jan 2020 22:38:02 -0500 Subject: [PATCH 1/2] revert "default jest watch unless in CI" PR revert "default jest watch unless in CI" PR --- src/index.ts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/index.ts b/src/index.ts index 2096a29c9..e059c8358 100755 --- a/src/index.ts +++ b/src/index.ts @@ -529,10 +529,6 @@ prog }) ); - if (!process.env.CI) { - argv.push('--watch'); // run jest in watch mode unless in CI - } - const [, ...argsToPassToJestCli] = argv; jest.run(argsToPassToJestCli); }); From cb082117037076b53b6f25679c78dbf1bb1e1e7d Mon Sep 17 00:00:00 2001 From: swyx Date: Wed, 8 Jan 2020 22:44:47 -0500 Subject: [PATCH 2/2] document reverting CI=true on tsdx test --- README.md | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 58ae2b0c7..261d22103 100644 --- a/README.md +++ b/README.md @@ -452,16 +452,14 @@ Examples ### `tsdx test` -This runs Jest v24.x in watch mode. See [https://jestjs.io](https://jestjs.io) for options. - -If you would like to disable watch mode, you can set the environment variable `CI=true`. For instance, you could set up your `package.json` `scripts` like: +This runs Jest v24.x. See [https://jestjs.io](https://jestjs.io) for options. For example, if you would like to run in watch mode, you can run `tsdx test --watch`. So you could set up your `package.json` `scripts` like: ```json { "scripts": { - "test": "CI=true tsdx test", - "test:watch": "tsdx test", - "test:coverage": "CI=true tsdx test --coverage" + "test": "tsdx test", + "test:watch": "tsdx test --watch", + "test:coverage": "tsdx test --coverage" } } ```