Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not running on windows #1

Open
legrandmawak opened this issue Oct 7, 2019 · 6 comments
Open

not running on windows #1

legrandmawak opened this issue Oct 7, 2019 · 6 comments

Comments

@legrandmawak
Copy link

this command requires unix based system.
ps is not a recognized command

@jaredly
Copy link
Owner

jaredly commented Oct 7, 2019

That's right. We could probably use something like https://github.com/indexzero/ps-tree or https://www.npmjs.com/package/ps-node to have cross-platform support

@scrthq
Copy link

scrthq commented Oct 9, 2019

Since we're using exec, which is in turn executing via cmd.exe on Windows, what about using tasklist, which is more or less the equivalent of ps on the Windows side? It could totally be missing dependent flags though that I'm not aware of. Time to spin up a new Linux VM to compare 😃 ...

thinking along the lines of setting the exec command to run based on underlying platform vs adding another dependency just to have a single, xplat command... digging into ps-tree a bit more and it looks like that's all it's doing under the hood, running platform specific commands that accomplish the same thing... will also check out ps-node

@jaredly
Copy link
Owner

jaredly commented Oct 10, 2019

that sounds great!

@DohanKim
Copy link

DohanKim commented Jul 26, 2022

Just in case anyone needs the feature,
I implemented it.
#8

@Maxim-Mazurok
Copy link

#8 didn't work for me, so I did #9

@Niels-c-Scholten
Copy link

Is this resolved in the latest version? I am still getting the error: "Error while listening for process end: Error: Command failed: ps -o tty 19044 'ps' is not recognized as an internal or external command...
I am running on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants