Error: Can't set headers after they are sent

[conorgil]

I have been trying to debug an error in my app for quite a while now and decided to run the example in this repo to reset my head and understand how everything should be hooked up correctly. However, when I ran the demo in this app, it spat out the same error that I am seeing in my app:

Error: Can't set headers after they are sent.
    at ServerResponse.OutgoingMessage.setHeader (http.js:691:11)
    at ServerResponse.res.setHeader (passport-yahoo/examples/signon/node_modules/express/node_modules/connect/lib/patch.js:63:22)
    at next (passport-yahoo/examples/signon/node_modules/express/node_modules/connect/lib/proto.js:156:13)
    at pass (passport-yahoo/examples/signon/node_modules/express/lib/router/index.js:110:24)
    at nextRoute (passport-yahoo/examples/signon/node_modules/express/lib/router/index.js:100:7)
    at callbacks (passport-yahoo/examples/signon/node_modules/express/lib/router/index.js:167:11)
    at complete (passport-yahoo/examples/signon/node_modules/passport/lib/middleware/authenticate.js:243:13)
    at passport-yahoo/examples/signon/node_modules/passport/lib/middleware/authenticate.js:250:15
    at pass (passport-yahoo/examples/signon/node_modules/passport/lib/authenticator.js:427:14)
    at Authenticator.transformAuthInfo (passport-yahoo/examples/signon/node_modules/passport/lib/authenticator.js:449:5)

Yahoo OpenID has been experiencing issues for a while, but shouldn't the passport module gracefully propagate this error up through the stack so that my next error handler middleware can handle the error correctly (redirect to an error page, for example).

• http://developer.yahoo.com/forum/OpenID-General-Discussion/OpenId-yahoo-is-broken-this-morning-/1396279008407-0e384032-f855-4dc6-82fb-9a03d7c1813a

After some googling, I reviewed the following pages (among others) and think I have my error handling setup correctly for once the passport module propagates the error up:

• Custom Authenticate Callback Not Called on Error passport#186
• https://stackoverflow.com/questions/15711127/express-passport-node-js-error-handling

Any thoughts?

[conorgil]

ping

[jpalardy]

Same problem. I found this by looking for "Can't set headers after they are sent."

[jpalardy]

The latest openid commit fixes this.