error: method save in class Canvas cannot be applied to given types; (when upgrading to react-native 0.59.5)

[killynathan]

Hi januslo,

When updating to react-native 0.59.5, we encountered the following error:

/node_modules/react-native-sunmi-inner-printer/android/src/main/java/com/sunmi/innerprinter/BitmapUtils.java:468: error: method save in class Canvas cannot be applied to given types;
                  canvas.save(Canvas.ALL_SAVE_FLAG); 
                        ^
  required: no arguments
  found: int
  reason: actual and formal argument lists differ in length
1 error

Upon researching, this seems to come from the fact that starting from Android SDK API 28, you cannot pass an int into canvas.save anymore. Is there any way you can help us with this?

Much thanks.

[leakhand]

Hi januslo,

When updating to react-native 0.59.5, we encountered the following error:

/node_modules/react-native-sunmi-inner-printer/android/src/main/java/com/sunmi/innerprinter/BitmapUtils.java:468: error: method save in class Canvas cannot be applied to given types;
                  canvas.save(Canvas.ALL_SAVE_FLAG); 
                        ^
  required: no arguments
  found: int
  reason: actual and formal argument lists differ in length
1 error

Upon researching, this seems to come from the fact that starting from Android SDK API 28, you cannot pass an int into canvas.save anymore. Is there any way you can help us with this?

Much thanks.

You can pull from my branch to fix this case

https://github.com/leakhand/react-native-sunmi-inner-printer/tree/fix/canvas

[killynathan]

@leakhand any interest of putting it on npm?

[leakhand]

@leakhand any interest of putting it on npm?

I've waited for the repository owner do merge request first

[januslo]

@leakhand merged

[killynathan]

@januslo thanks so much for your support. Can you please update npm to have this version?

[datvp09]

please release new version, still having this issue