Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot send Accept-Encoding with net::http #91

Open
rgalanakis opened this issue Nov 5, 2024 · 0 comments
Open

Cannot send Accept-Encoding with net::http #91

rgalanakis opened this issue Nov 5, 2024 · 0 comments

Comments

@rgalanakis
Copy link

See this commit: 8623385#diff-e9b8a9ac06b9fed71d2486fb9ee9ad12bddaca2e7f51290640f5c3722d5b7a20R256

Is this workaround still needed?

I suspect it's also related to #87

rgalanakis added a commit to webhookdb/webhookdb that referenced this issue Nov 5, 2024
Some servers REQUIRE text/calendar in 'Accept',
so add it before '*/*'.

Also fix a problem where Down was
setting Accept-Encoding header to '',
which meant we usually weren't getting zipped encoding.

This was fixed by using down/httpx instead of down/http.
However this change ended up requiring a whole bunch
of other small changes since the Down backends
do not work so consistently.

See janko/down#91
rgalanakis added a commit to webhookdb/webhookdb that referenced this issue Nov 5, 2024
Some servers REQUIRE text/calendar in 'Accept',
so add it before '*/*'.

Also fix a problem where Down was
setting Accept-Encoding header to '',
which meant we usually weren't getting zipped encoding.

This was fixed by using down/httpx instead of down/http.
However this change ended up requiring a whole bunch
of other small changes since the Down backends
do not work so consistently.

See janko/down#91
rgalanakis added a commit to webhookdb/webhookdb that referenced this issue Nov 5, 2024
Some servers REQUIRE text/calendar in 'Accept',
so add it before '*/*'.

Also fix a problem where Down was
setting Accept-Encoding header to '',
which meant we usually weren't getting zipped encoding.

This was fixed by using down/httpx instead of down/http.
However this change ended up requiring a whole bunch
of other small changes since the Down backends
do not work so consistently.

See janko/down#91
rgalanakis added a commit to webhookdb/webhookdb that referenced this issue Nov 6, 2024
Some servers REQUIRE text/calendar in 'Accept',
so add it before '*/*'.

Also fix a problem where Down was
setting Accept-Encoding header to '',
which meant we usually weren't getting zipped encoding.

This was fixed by using down/httpx instead of down/http.
However this change ended up requiring a whole bunch
of other small changes since the Down backends
do not work so consistently.

See janko/down#91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant