Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remote APIs can fetch Model List #3374

Closed
4 of 6 tasks
Tracked by #3365 ...
Van-QA opened this issue Aug 15, 2024 · 2 comments
Closed
4 of 6 tasks
Tracked by #3365 ...

feat: Remote APIs can fetch Model List #3374

Van-QA opened this issue Aug 15, 2024 · 2 comments
Labels
P1: important Important feature / fix type: feature request A new feature

Comments

@Van-QA
Copy link
Contributor

Van-QA commented Aug 15, 2024

Goal

  • Remote API Extensions can fetch an updated model list (e.g. params that can be passed in)
  • Users can select model from list, once
  • Users should only see major models (i.e. not nightly)
  • We will not need model.yaml for each remote model
  • [Stretch] Users can add additional model names in the Remote API's Settings page (e.g. nightly)

Tasklist

Archive

Fetch list of remote models per engine via API => No need to add model json for each remote model

Remote engines: reuse from Jan with a few modifications for more remote models (mentioned abo‌ve) -> Hash user api key - raw content - remove -> files still there

@Van-QA Van-QA added this to the v.0.6.0 milestone Aug 15, 2024
@Van-QA Van-QA changed the title feat: Hub - Remote model list should be auto populated from remote engines feat: Hub / Engine - Remote model list should be auto populated from remote engines Aug 15, 2024
@Van-QA Van-QA modified the milestones: v.0.6.0, v.0.6.1 Aug 15, 2024
@louis-jan
Copy link
Contributor

louis-jan commented Aug 30, 2024

Strict tests on model fetching are required for the update, e.g., sometimes the service could be down during the build and the app bundles an empty list of models.

Possible situation:

  • App passed during manual tests / dev
  • Request failed during bundle for release (tag trigger)

Suggestion:
Before:

  • Test = run Test
  • Publish = Bundle -> Distribute
    After:
  • Publish = Bundle -> Test -> Distribute

@0xSage 0xSage added the P1: important Important feature / fix label Sep 5, 2024
@dan-homebrew dan-homebrew changed the title feat: Hub / Engine - Remote model list should be auto populated from remote engines feat: Remote APIs fetch model list Sep 10, 2024
@dan-homebrew dan-homebrew changed the title feat: Remote APIs fetch model list feat: Remote APIs can fetch Model List Sep 10, 2024
@dan-homebrew
Copy link
Contributor

I am merging this issue into #3505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1: important Important feature / fix type: feature request A new feature
Projects
Archived in project
Development

No branches or pull requests

6 participants