Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/feat: Windows uninstall should delete the Jan Data Folder #2377

Closed
0xSage opened this issue Mar 15, 2024 · 5 comments · Fixed by #2705
Closed

bug/feat: Windows uninstall should delete the Jan Data Folder #2377

0xSage opened this issue Mar 15, 2024 · 5 comments · Fixed by #2705
Assignees
Labels
type: bug Something isn't working

Comments

@0xSage
Copy link
Contributor

0xSage commented Mar 15, 2024

Describe the bug
A clear and concise description of what the bug is.

Steps to reproduce
Steps to reproduce the behavior:

  1. Windows > Add or Remove programs
  2. Uninstall Jan
  3. Jan Data Folder still persists after uninstallation
@0xSage 0xSage added the type: bug Something isn't working label Mar 15, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Mar 15, 2024

Additional Note:

  • Currently, no folders or data are being removed when uninstalling the Jan app. Only the Jan app itself is deleted.
  • This is why we have not documented any folders or data that users should expect to disappear after uninstallation.
  • We will update this information once the removal process is implemented or if possible, please help us with a doc page to highlight that we are not removing any data yet, linking to this issue for reference @hieu-jan

Linking related ticket: #1435, #1654

@dan-homebrew
Copy link
Contributor

I'm personally not sure if we should delete the Jan Data Folder if Jan is deleted.
This data belongs to them, not to Jan = they may want to use the models, conversaions with different apps in the future

@0xSage
Copy link
Contributor Author

0xSage commented Mar 16, 2024 via email

@Van-QA Van-QA added this to the v0.4.12 milestone Apr 10, 2024
@louis-jan louis-jan assigned hiento09 and unassigned louis-jan Apr 10, 2024
@hiento09 hiento09 mentioned this issue Apr 12, 2024
3 tasks
@Van-QA Van-QA modified the milestones: v0.4.12, v0.4.13 Apr 16, 2024
@Van-QA Van-QA mentioned this issue Apr 16, 2024
6 tasks
@hiento09
Copy link
Collaborator

PR #2705 When a user uninstalls the Jan app via the Windows Control Panel, the following notification will be displayed:
image

If a user changes the Jan Data folder, since this folder belongs to the user, it will not be deleted. cc @dan-jan , @0xSage , @Van-QA

@Van-QA
Copy link
Contributor

Van-QA commented Apr 17, 2024

If a user changes the Jan Data folder, since this folder belongs to the user, it will not be deleted.

Note that reinstallation at this stage will be a clean install, Jan app no longer connected to the existing Jan data folder (that remains from the previous step)

1. Users will have to override the data manually if needed, which is why we need a correction of the message to

image
Do you also want to delete the **default** Jan data folder at ...
cc: @hiento09

2. Update the popup of move Jan data folder:

image

  • Correct the msg for all OS:
    Are you sure you want to relocate Jan data folder to C:\Users\ptvan\Downloads\New folder? A restart will be required afterward, and the original folder will remain intact.
  • Add this msg for windows only:
    Note that Jan will not erase the new Jan data folder during future uninstallation.

cc: @namchuai

3. And also document this on our website 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants