-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update es_ES app translation for 3.10.0 #3122
Comments
Closing as #3119 includes translation by @ignotus666 |
You already know that probably, but I messed up. @ignotus666 could you please check if the weblate PR #3119 is correct? |
@ann0see looks good. But a bunch of stuff got lost from the website translation. Did this happen because an EN PR got merged before the Weblate stuff? When that happens isn't the easiest fix to just revert the offending PR, merge the Weblate PR, and then merge it? It's what I did on previous occasions and it wasn't too much hassle. |
Yes. But there was no new weblate PR. The stuff was not yet committed on weblate. |
Ah, I see. |
I think I recall a discussion about preventing changes to EN files being merged if a weblate PR was present, but it still wouldn't protect against this scenario. Maybe a warning in the PR template to make sure everything has been committed, pushed and merged from Weblate first as a reminder? |
No. I think we'd need to manage the .po file creation differently - they cause the conflicts. |
I'm all ears, but I don't see how - I think it's a problem inherent to how Weblate works. |
Kind of. But there should be an easy way to fix conflicts- I can't connect to their repo. I believe the po file generation should be linked to the current state on Weblate. Maybe there's an API. |
Not sure it has anything to do with it, but you have to make sure you connect to the right branch on Weblate's fork - I was looking at |
So is next-release wrong on jamulussoftware/jamuluswebsite??? Edit: ok. Only on the Weblate fork |
Hi @ignotus666,
We are getting ready for the 3.10.0 release. No further changes to translatable strings are currently planned for this release.
We would be happy if you updated the Jamulus software translations for es_ES by 2023-08-20.
Please either update the translations on Hosted Weblate or use Git:
jamulussoftware/jamulus
main
and create a working branchSuggested commit and PR message:
Further documentation can be found in TRANSLATING.md.
Thanks for contributing to Jamulus!
The text was updated successfully, but these errors were encountered: