Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeBucket does not allow for extra arguments allowed by timescaledb #43

Open
tales42 opened this issue Mar 17, 2023 · 2 comments
Open

Comments

@tales42
Copy link

tales42 commented Mar 17, 2023

The current implementation of TimeBucket only allows the use of the required arguments (bucket_width and ts).

It would be nice if the remaining arguments could be used as well with the package.
The available argument combinations are as follow:

  • time_bucket(bucket_width, ts)
  • time_bucket(bucket_width, ts, offset)
  • time_bucket(bucket_width, ts, origin)
  • time_bucket(bucket_width, ts, timezone, origin, offset)
@tales42
Copy link
Author

tales42 commented Mar 17, 2023

Opened a PR for it: #44

Did not include support for timezone, because could not find a way to send a named parameter into the db function

@caullla
Copy link

caullla commented Aug 31, 2024

what if make all args required? you still will be able to pass None when calling the function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants