Skip to content
This repository has been archived by the owner on Nov 2, 2022. It is now read-only.

Inconsistency in method naming settings endpoint for 'always_online' #82

Open
holtkamp opened this issue Oct 24, 2017 · 0 comments
Open

Comments

@holtkamp
Copy link
Contributor

holtkamp commented Oct 24, 2017

For the settings endpoint the following methods are typically available:

  • setting_name($zone_identifier)
  • change_setting_name($zone_identifier)

This allows to create a command which takes a setting name as parameter can then use:

  • $method = sprintf('change_%s', $settingName)

However, an inconsistency prevents this to work with the 'always online' setting:

Changing the name of this method to realize consistency would mean a BC-break. So an alias might be considered?

As far as I can see this is the only inconsistency. The following method seems missing:

  • change_email_obfuscation()
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant