Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intended use with sprockets + cssbundling-rails and jsbundling-rails? #132

Closed
ivy opened this issue Nov 15, 2021 · 2 comments
Closed

Intended use with sprockets + cssbundling-rails and jsbundling-rails? #132

ivy opened this issue Nov 15, 2021 · 2 comments

Comments

@ivy
Copy link

ivy commented Nov 15, 2021 •
edited
Loading

I see that the inline_svg helper is deprecated in favor of inline_svg_pack_tag but this seems to require Webpacker. What should we be doing for Rails apps using Hotwire (Stimulus and Turbo) with cssbundling-rails and jsbundling-rails?
@jamesmartin
Copy link
Owner

👋 @ivy, thanks for opening this issue. We've actually reversed the decision to deprecate the inline_svg method (#131). This was going to be deprecated in version 2.0 but we decided that it would be better to allow the gem to be configured to use Sprockets or Webpacker. This should mean fewer code changes for people upgrading from v1.x to v2.x, when that eventually happens.

@ivy
Copy link
Author

ivy commented Nov 17, 2021

Awesome! Thank you for clarifying!

@ivy ivy closed this as completed Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesmartin @ivy