Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: add aria-label to <path> #104

Open
rhymes opened this issue Oct 30, 2019 · 1 comment
Open

Feature request: add aria-label to <path> #104

rhymes opened this issue Oct 30, 2019 · 1 comment
Labels
enhancement help wanted

Comments

@rhymes
Copy link

rhymes commented Oct 30, 2019

I was running a website through the Firefox Accessibily inspector and I get the following error on the <path> element of the SVG generated through this gem:

Screenshot 2019-10-30 at 4 41 02 PM

This disappears the second I add aria-label to the <path>.

Since path supports ARIA attributes as well, the aria: true should generated a label for that as well.
@jamesmartin
Copy link
Owner

Thanks for opening this issue, @rhymes. ✨

This seems like a reasonable request to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesmartin @rhymes