Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error with TypeScript 4 #81

Open
qurben opened this issue Jan 22, 2021 · 0 comments · May be fixed by #82
Open

Error with TypeScript 4 #81

qurben opened this issue Jan 22, 2021 · 0 comments · May be fixed by #82

Comments

@qurben
Copy link

qurben commented Jan 22, 2021

In cancellable-promise.ts

Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?ts(2794)

jgallery/src/utils/cancellable-promise.ts

Line 26 in 7f517e2

resolve();

Resolve should be called with a value if the type argument for Promise is not void (which it is not here)
@qurben qurben changed the title Error with TypeScript 4` Error with TypeScript 4 Jan 22, 2021
qurben added a commit to csrdelft/jgallery that referenced this issue Jan 22, 2021
@qurben
Fix jakubkowalczyk-pl#81, explicitely return null in Promise
a253c46
@qurben qurben linked a pull request Jan 22, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicitely return null in Promise csrdelft/jgallery
1 participant
@qurben