Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python example does not handle chunking correctly #2

Open
graingert opened this issue Oct 21, 2013 · 2 comments
Open

python example does not handle chunking correctly #2

graingert opened this issue Oct 21, 2013 · 2 comments

Comments

@graingert
Copy link

This code ignores the chunk number for values greater than 0.

individual chunks should be saved to individual destinations, then joined once all chunks exist. Upload requests could arrive in any order!

@jakobadam
Copy link
Owner

Hi

The chunk number is used to resume downloads.

Since the client currently only uses one connection and sends chunks in sequence, they are just appended to one destination file at the server side; making the code need only read the uploaded data once.

If there were multiple connections I agree.

-- Jakob

@graingert
Copy link
Author

HTTP is a stateless protocol, each request should be treated independently, using only one connection at a time is not part of the public interface to the PLupload client it's just an implementation detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants