Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate package for Restrictions #933

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

njr-11
Copy link
Contributor

@njr-11 njr-11 commented Jan 7, 2025

Fixes #931
This moves the 9 classes that we have for restrictions into their own package so that they don't overwhelm the main jakarta.data package.

@njr-11 njr-11 added this to the 1.1 milestone Jan 7, 2025
@otaviojava
Copy link
Contributor

@njr-11 I agree with you that you need to discuss this one more.
IMHO: I only see Restrictions to be used with the static model conflicts, thus, it should be on the metadata domain/package

@otaviojava
Copy link
Contributor

@njr-11 please, rebase this code.

@njr-11 njr-11 force-pushed the 931-separate-package-for-restrictions branch from e21f832 to f101b31 Compare January 13, 2025 14:41
@njr-11
Copy link
Contributor Author

njr-11 commented Jan 13, 2025

@njr-11 please, rebase this code.

Done. Thanks for pointing this out. It was needed to resolve a merge conflict.

@njr-11 I agree with you that you need to discuss this one more.
IMHO: I only see Restrictions to be used with the static model conflicts, thus, it should be on the metadata domain/package

It could make sense to put it under metamodel. I'll wait for the meeting on Wednesday to get feedback on what everyone thinks is the ideal place for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

separate package for restrictions
2 participants