Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated_at isn't set on instance creation #1

Open
jimrollenhagen opened this issue Aug 9, 2015 · 2 comments
Open

updated_at isn't set on instance creation #1

jimrollenhagen opened this issue Aug 9, 2015 · 2 comments

Comments

@jimrollenhagen
Copy link

I think it makes sense to set updated_at to the current time on events.beforeInsert. Many frameworks implement this behavior this way, and it seems better for application usage to avoid doing null checks on this field, etc.

Thoughts?
@jimrollenhagen
Copy link
Author

I'm happy to do the work to implement this, FWIW

@lukejagodzinski
Copy link
Member

Yes, you are right, I forgot about this. Feel free to create PR :) Thanks!

jimrollenhagen added a commit to jimrollenhagen/meteor-astronomy-timestamp-behavior that referenced this issue Aug 16, 2015
@jimrollenhagen
Set updated field on instance create
9d153d5 
To be more in line with how other frameworks implement this behavior,
and for application sanity, set the "updated at" field during
beforeInsert.

Closes jagi#1
@jimrollenhagen jimrollenhagen mentioned this issue Aug 16, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimrollenhagen @lukejagodzinski