Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defaultUpperBoundTracesPerSecond from PerOperationSamplingStrategies in sampling.thrift #46

Open
black-adder opened this issue Mar 29, 2018 · 2 comments
Open

Remove defaultUpperBoundTracesPerSecond from PerOperationSamplingStrategies in sampling.thrift #46

black-adder opened this issue Mar 29, 2018 · 2 comments

Comments

@black-adder
Copy link
Contributor

defaultUpperBoundTracesPerSecond was going to be used to throttle the number of traces that were generated but we've moved onto using an actual throttler. This variable is no longer necessary
@yurishkuro
Copy link
Member

doesn't throttler only apply to debug traces?

@black-adder
Copy link
Contributor Author

yesh but no reason it cant be used for all sampling decisions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@black-adder @yurishkuro