Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source code for modified Louvain? #9

Open
AvantiShri opened this issue Dec 10, 2017 · 5 comments
Open

Source code for modified Louvain? #9

AvantiShri opened this issue Dec 10, 2017 · 5 comments

Comments

@AvantiShri
Copy link

Hello,

Thanks a lot for your work! As a python user, I have found it is way easier to call the Louvain code using your code base than to use their provider Python package (which is quite slow).

The phenograph readme mentions that you use a modified version of Louvain community detection. Any chance you can make the source code for this modified version available? I need to make a small change to make the results deterministic, but I am not a C++ programmer so it would really help to start with what you already have rather than try to replicate your described modification from scratch.

@SamGG
Copy link

SamGG commented Dec 10, 2017

Hi,
While Jacob will give a clear answer, the readme of the Louvain code seems to be exactly the one of Jean-Loup Guillaume (http://jlguillaume.free.fr/www/). You can find this source code https://sourceforge.net/projects/louvain/files/
HTH

@AvantiShri
Copy link
Author

What about this readme? https://github.com/jacoblevine/PhenoGraph/blob/master/phenograph/louvain/phenograph-readme.txt

"For PhenoGraph, the C++ louvain code has been adapted to increase speed.
Specifically, graphs are written directly to binary format and the rewritten
louvain binary "convert" is expecting a binary file to operate on."

@SamGG
Copy link

SamGG commented Dec 11, 2017

Right. No idea except a memory dump of the object.

@AvantiShri
Copy link
Author

AvantiShri commented Dec 13, 2017

Assuming the changes as described are indeed just limited to the convert binary, I changed the community binary (which is where the random seed gets set) and I think I'm good. My modified source code is here: https://github.com/kundajelab/deterministic_louvain.

Thanks!

@AvantiShri
Copy link
Author

Just pinging @jacoblevine again to see if there is any chance of getting the modified convert binary source code. Providing precompiled binaries does not always work for all systems (e.g. it appears to break on newer versions of OSX), so it would be nice if people could install from source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants