Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haburger menu for explorer in mobileonly() clause #1776

Open
OfirSinn opened this issue Feb 18, 2025 · 1 comment
Open

haburger menu for explorer in mobileonly() clause #1776

OfirSinn opened this issue Feb 18, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@OfirSinn
Copy link

OfirSinn commented Feb 18, 2025

Describe the bug
when Component.Explorer() in layout.ts is configured as Component.MobileOnly(Component.Explorer()), then when in mobile mode and the haburger menu is visible, it opens correctly, but the icon to close it is gone, meaning you cannot leave the explorer menu to the page you by pressing the menu again. the only way to leave the menu is by pressing on a given note.

To Reproduce

  1. Go to 'layout.ts'
  2. change Component.Explorer() to Component.MobileOnly(Component.Explorer())
  3. build
  4. See error

Expected behavior
The expectation is that the explorer, when in hamburger menu mode, would behave normally. Meaning, being able to enter and leave the menu by pressing on the hamburger menu.

video
explorer component unchanged (expected)
explorer in mobileonly clause

Desktop (please complete the following information):

  • Quartz Version: v4.4.0 (latest)
  • node Version: v22.12
  • npm version: v11.0.0
  • OS: mobile/windows
  • Browser chrome

Additional context
I would like to be able to have my explorer on desktop on the right (since I write in RTL) but the hamburger menu needs to stay in the left component section.

@OfirSinn OfirSinn added the bug Something isn't working label Feb 18, 2025
@OfirSinn
Copy link
Author

OfirSinn commented Feb 18, 2025

After a bit of reading I realize that in general have multiples of the same component is problematic anyway (to be clear, the bug happens even if Component.MobileOnly(Component.Explorer()) is the only instance of the eplorer component).
So my solution would be having the hamburger menu always be in the top left, regardless of where component explorer is placed, since the is no real reason for it to be anywhere else, it is a known design cue.

@saberzero1 saberzero1 self-assigned this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants