Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better common lisp support #414

Open
dieggsy opened this issue Feb 16, 2022 · 3 comments
Open

Better common lisp support #414

dieggsy opened this issue Feb 16, 2022 · 3 comments

Comments

@dieggsy
Copy link

dieggsy commented Feb 16, 2022

Looking at the common lisp rules, things like defmethod, defclass, and defvar aren't supported. I would think at minimum these three should be added, since they're used everywhere in CL.

I'd be happy to open a PR if that's preferrable, though it may take me a minute to get around to it.

@jacktasia
Copy link
Owner

Thanks for opening this. A PR for these is definitely welcome.

dieggsy added a commit to dieggsy/dumb-jump that referenced this issue Feb 18, 2022
Support defmethod, defclass, deftype, defparameter, defconstant

Fixes jacktasia#414
@dieggsy
Copy link
Author

dieggsy commented Feb 19, 2022

I've added an initial pass at this in my fork which seems to be mostly working, but it looks like it's searching case-sensitively by default. Is there any way to change the case sensitivity or search options per language?

@phikal
Copy link
Contributor

phikal commented Feb 19, 2022

It looks like you are going to have to change the command generator functions (the ones set by :generate in dumb-jump-generators-by-searcher to insert a case-insensitivity flag when the language is case-insenstive. I'd say adding a defconst with case-insensitive languages (CL should be enough for now) would be the best way to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants