Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too verbose tests #2

Open
apaatsio opened this issue Oct 22, 2018 · 0 comments
Open

Too verbose tests #2

apaatsio opened this issue Oct 22, 2018 · 0 comments
Assignees

Comments

@apaatsio
Copy link

Some tests could be refactored to make them simpler.

For example:

bool stateIsNotNull = false;
PaymentDetails page = PaymentDetails();
var state = page.createState();
stateIsNotNull = state != null;
expect(stateIsNotNull, true);

Could be written just

PaymentDetails page = PaymentDetails();
expect(page.createState(), isNotNull);

There were other tests also that used a similar pattern.

@jaaaxsonmh jaaaxsonmh self-assigned this May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants