-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] 0.18.4 tdl restores context in weird way #865
Comments
Does this situation occur in the old version? |
As far as i know, in the old version it just gets stuck forever (for example with above log, old version gets stuck forever downloading 1 and 2) |
@tdlbugreport Are there any old versions with stable work? I want to check their diffs. |
Well, i dont have old logs to compare for now(if you meant that). i used v0.18.3 before recent v0.18.4 update. if you want me to, i can report back with download logs after trying to download them on v0.18.3 but obviously it will take a day to generate them. |
possible relevant log/issue: #854 |
@iyear this seems to be critical issue. seems like tdl is marking those "paused" files as completed (file extensions are also changed to original ones just like it's fully downloaded) and does not redownload them even after force (ctrl+c) termination, which disguises corrupted files as a complete files. |
Describe the bug
It restores the context to download new file instead of continuing currently downloading file, which draws this functionality actually useless, especially when you are QoS'd by TG server.
1 2 download gets "paused", then 3 4 gets continued by ctx restore, and then 5 6... infinite loop just like this. in the end you have to disregard them all because you actually gets nothing, as tdl doesn't have functionality of resuming from downloaded point after session restart.
To Reproduce
tdl dl -f tdl-export.json --pool 0 -t 2 -l 2 --debug --continue --skip-same --reconnect-timeout 0
as you can see, 1,2 and 3,4 files are actually never resumed from 5~8hrs of download queue.
Expected behavior
It should continue downloading "paused" file instead of starting new download.
Version
Version: 0.18.4
Commit: 8728f56
Date: 2025-01-23T07:19:57Z
go1.21.13 windows/amd64
Which OS are you running tdl on?
Windows
Additional context
Written in reproduce space.
The text was updated successfully, but these errors were encountered: