Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxSFLineShape::SetStartingConnectionPoint does not update the source shape ID #8

Open
iwbnwif opened this issue Aug 16, 2016 · 0 comments

Comments

@iwbnwif
Copy link
Owner

iwbnwif commented Aug 16, 2016

When setting a line's starting point to a connection point, it is also necessary to separately update the source shape's ID.

There does not appear to be a good reason for this, so I propose to add:

SetSrcShapeId(cp->GetParentShape()->GetId()); to the wxSFLineShape::SetStartingConnectionPoint method and similarly SetTrgShapeId(cp->GetParentShape()->GetId()); to the wxSFLineShape::SetEndingConnectionPoint method.

Both additions should be made within the guarding 'if' statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant