-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atnaujinta pagal LDES pakeitimus #24
Conversation
Signed-off-by: Vladimiras Desiatnikovas <[email protected]>
Signed-off-by: Vladimiras Desiatnikovas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reikėtu pilno pavyzdžio, aiškinamojoje dalyje, nes dabar nematau, kaip tai galėtu veikti, dabar neaišku, iš kur bus gaunamas SHACL, kokios bus naudojamas fragmentacijos būdas.
Lyg ir nurodyta, kad fragmentuojama pagal tree:GreaterThanOrEqualToRelation
, bet neaišku, ar bus filtruojama pagal keitimo datą?
Jei changes schema yra fiksuota, tai klausimas, kodėl nurodyta sh:path
, kuris yra SHACL konstruktas, o mes turime JSON, kuriame sh:path
nieko nereiškia.
Nesupratu, kaip tai galėtu veikti.
_data: | ||
_shape: | ||
type: string | ||
description: A tree:shape element represented as a string that provides a relative path to the corresponding {name}.schacl shape document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UDTS yra JSON REST API, klausimas iš kur gausime SHACL?
type: array | ||
description: A collection of one or many tree:member elements | ||
items: | ||
$ref: ./change.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Klausimas ar mums tikrai reikia atskiro _member
, ar neužtenka _data
ir @context
, kuris visus objektus deklaruotų kaip tree:member
?
Nes dabar API gausis per daug fragmentuotas: event streem -> members -> change. Reika labai daug užklausų, kad gauti duomenis.
items: | ||
$ref: ./change.yaml | ||
_view: | ||
$ref: ./_view.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Siūlau palikti, dabartinį _next
pavadinimą, o tree:view
nurodyti JSON-LD kontekste.
@@ -73,7 +73,7 @@ paths: | |||
$ref: paths/wipe.yaml | |||
/{group}/{form}/{org}/{catalog}/{dataset}/{version}/{model}/{id}/{property}: | |||
$ref: paths/property.yaml | |||
/{group}/{form}/{org}/{catalog}/{dataset}/{version}/{model}/:changes/{cid}: | |||
/{group}/{form}/{org}/{catalog}/{dataset}/{version}/{model}/:changes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jei panaikiname puslapiavimą, pagal keitimo id, klausimas, kaip gausime sekantį puslaptį?
Remtasi Manto komentaru.
Pakeitimai ir jų tikslai:
a. atnaujinta changes schema su view elementu ir paaiškinimu
b. atnaujintas changes path
c. atnaujintas query
a. atnaujinta changes schema, kuri dabar atspindi ldes:EventStream schemą
b. atnaujinta change schema, kuri dabar atspindi tree:member schemą