Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MANGO model #38

Open
glemson opened this issue Apr 20, 2021 · 5 comments
Open

MANGO model #38

glemson opened this issue Apr 20, 2021 · 5 comments

Comments

@glemson
Copy link
Contributor

glemson commented Apr 20, 2021

Regarding the MANGO model

I am using a particular commit in my mapping, namely
https://raw.githubusercontent.com/ivoa-std/MANGO/a46441f6fc498a6aeb33ed97e65689fee3d00f6c/vo-dml/mango.vo-dml.xml
Referring only to the "last" commit may break certain mappings if the model changes.
Should do the same with the Cube and the various STC models I suppose.
I ran into some issues there that MCD fixed.

It would be nice if all the mappings that we compare here use exactly the same versions of the models. Can we define such a set? Note that these need to be internally consistent as well when considering model imports.

There are some problems with the VO-DML for that mango model:

The validation in the volute vo-dml folder produces some xsd problems, mainly pattern validation errors caused by leading spaces.

More importantly the following model errors were found:

  • Target role of subsets constraint on 'exterrors.MultiParamError1D' with vodml-ref mango:errors.MultiParamError.correlatedErrors can not be found
  • Target role of subsets constraint on 'exterrors.MultParamErro2D' with vodml-ref mango:exterrors.MultiParamError.correlatedErrrors can not be found
  • datatype mango:extcoords.FlagState of composition extcoords.FlagSys.statusLabels is not an object type but a 'dataType'
@lmichel
Copy link
Collaborator

lmichel commented Apr 20, 2021

Thank you for pointing these issues.
MANGO has been successfully validated with you ant script, I likely miss some warnings.

Both MANGO and ModelInstanceInVot have been frozen for the workshop duration.
We have now many feature requests for both.

Unfortunately, some datasets have been annotated long time before the last MANGO commit.
I fix them one by one but it is very time consuming,

@glemson
Copy link
Contributor Author

glemson commented Apr 20, 2021

I used the ant script and got that result.

@glemson
Copy link
Contributor Author

glemson commented Apr 20, 2021

Laurent, which of the mappings you have here in the use cases shold I look at for the frozen model and mapping spec? And which is the mapping spec? In C:\workspaces\IVOA\GIT\modelinstanceinvot-code/schema I see two xsd files, very similar but not the same. Which have you used?

@lmichel
Copy link
Collaborator

lmichel commented Apr 20, 2021

https://github.com/ivoa-std/ModelInstanceInVot/blob/master/schema/model-instance-in-vot.xsd

There are code samples here

  • Need a push (I'll notify you(
  • Code developed as long as the schema: everything is moving

@mcdittmar
Copy link
Collaborator

mcdittmar commented Apr 20, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants