-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MANGO model #38
Comments
Thank you for pointing these issues. Both MANGO and ModelInstanceInVot have been frozen for the workshop duration. Unfortunately, some datasets have been annotated long time before the last MANGO commit. |
I used the ant script and got that result. |
Laurent, which of the mappings you have here in the use cases shold I look at for the frozen model and mapping spec? And which is the mapping spec? In C:\workspaces\IVOA\GIT\modelinstanceinvot-code/schema I see two xsd files, very similar but not the same. Which have you used? |
https://github.com/ivoa-std/ModelInstanceInVot/blob/master/schema/model-instance-in-vot.xsd There are code samples here
|
Gerard,
I'm using the IVOA repository versions of the base models: (ivoa, coords,
meas, trans)
* though transform is not used in any of the workshop cases
For Cube, Dataset, and PhotDM I'm using the most recent volute version
since they are not uploaded to the repository.
Mango I've pulled Laurent's file locally to generate the classes, etc..
could tighten that up.
def voluteBase = "https://volute.g-vo.org/svn/trunk/projects/dm"
def ivoaBase = "https://www.ivoa.net/xml"
def ivoaLocation = new URL("$ivoaBase/VODML/IVOA-v1.vo-dml.xml")
def coordsLocation = new
URL("$ivoaBase/STC/20200908/Coords-v1.0.vo-dml.xml")
def measLocation = new URL("$ivoaBase/Meas/20200908/Meas-v1.0.vo-dml.xml")
def photLocation = new
URL("$voluteBase/vo-dml-org/models/photdm-alt/PhotDM-alt.vo-dml.xml")
def dsLocation = new
URL("$voluteBase/DatasetMetadata/vo-dml/DatasetMetadata-1.0.vo-dml.xml")
def cubeLocation = new URL("$voluteBase/Cube/vo-dml/Cube-1.0.vo-dml.xml")
def mangoLocation = new
URL("file:/Users/sao/Documents/IVOA/GitHub/ivoa-dm-examples/tmp/Mango-v1.0.vo-dml.xml")
|
Regarding the MANGO model
I am using a particular commit in my mapping, namely
https://raw.githubusercontent.com/ivoa-std/MANGO/a46441f6fc498a6aeb33ed97e65689fee3d00f6c/vo-dml/mango.vo-dml.xml
Referring only to the "last" commit may break certain mappings if the model changes.
Should do the same with the Cube and the various STC models I suppose.
I ran into some issues there that MCD fixed.
It would be nice if all the mappings that we compare here use exactly the same versions of the models. Can we define such a set? Note that these need to be internally consistent as well when considering model imports.
There are some problems with the VO-DML for that mango model:
The validation in the volute vo-dml folder produces some xsd problems, mainly pattern validation errors caused by leading spaces.
More importantly the following model errors were found:
The text was updated successfully, but these errors were encountered: