Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify the REGION function with reference to DALI shape #90

Open
pdowler opened this issue Jun 7, 2023 · 3 comments
Open

specify the REGION function with reference to DALI shape #90

pdowler opened this issue Jun 7, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@pdowler
Copy link

pdowler commented Jun 7, 2023

Once DALI specifies xtype="shape" this provides a replacement for the non-normative usage of "adql:region" from TAP-1.0 with something that is a normative part of a standard, with most of the features intact (polymorphism) and the sketchy bits removed (coordsys that could change from row to row).

This will be in DALI-1.2 (subtle details close to worked out) so we could consider it for later, but ADQL-next could be a long way off so I would prefer get it into ADQL-2.1 if we can.

@msdemlei
Copy link
Contributor

msdemlei commented Jun 9, 2023 via email

@gmantele
Copy link
Collaborator

Sorry for answering so late...last weeks were so crazy 🙃

Thank you very much @pdowler for this good piece of news :-) It is indeed really interesting for, at least, Obscore+TAP.

But, as much as I would like to include shape and MOC inside ADQL, I agree with Markus: this should not delay ADQL-2.1 which made so much time to finally be released. I also agree that next versions of ADQL should be released much faster than that, and especially ADQL-2.2 with PEG and MOC. I think it is ok (and even preferable) that DALI releases the shape and MOC xtypes before ADQL-2.2 uses them. In the meantime, nothing prevents TAP service providers to use them in their service. Besides, it will take also some time too for Obscore to adapt its specification to this new shape ; in a way, releasing ADQL and then Obscore so that following the new DALI-REC seems perfectly ok to me.

@pdowler
Copy link
Author

pdowler commented Jun 19, 2023

OK, that sounds reasonable. Please mark this as "enhancement" for a future version.

@gmantele gmantele added the enhancement New feature or request label Sep 21, 2023
@gmantele gmantele added this to the future-version milestone Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants