Check warnings

Author: Nesterov Alexander

.travis.yml

@@ -25,4 +25,4 @@ script:
   - mpirun -np 4 ./modules/task_1/Yakovlev_Pavel_mul_vect/Yakovlev_Pavel_mul_vect 100000
   - mpirun -np 4 ./modules/task_1/Perov_Dima_task1_SumElVect/Perov_Dima_task1_SumElVect 10000
   - mpirun -np 4 ./modules/task_1/vikhrev_array_sum/vikhrev_array_sum 10 10
-  - mpirun -np 4 ./modules/task_1/Vdovin_Eugene_task1_NumWords/Vdovin_Eugene_task1_NumWords 300000000
+  - mpirun -np 4 ./modules/task_1/Vdovin_Eugene_task1_NumWords/Vdovin_Eugene_task1_NumWords 3000000

CMakeLists.txt

@@ -7,4 +7,14 @@ if( MPI_FOUND )
     include_directories( ${MPI_INCLUDE_PATH} )
 endif( MPI_FOUND )
 
+if ( UNIX )
+    set(CMAKE_C_FLAGS  "${CMAKE_CXX_FLAGS} -Wall -Werror")
+    set(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} -Wall -Werror")
+endif( UNIX )
+
+if ( MSVC )
+    set(CMAKE_C_FLAGS  "${CMAKE_CXX_FLAGS} /WX")
+    set(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} /WX")
+endif( MSVC )
+
 add_subdirectory(modules)

appveyor.yml

@@ -49,4 +49,4 @@ build_script:
   - cmd: mpiexec.exe -np 4 modules\task_1\Perov_Dima_task1_SumElVect\%configuration%\Perov_Dima_task1_SumElVect.exe 10000
   - cmd: mpiexec.exe -np 4 modules\task_1\vikhrev_array_sum\%configuration%\vikhrev_array_sum.exe 10 10
   - cmd: mpiexec.exe -np 4 modules\task_1\Yakovlev_Pavel_mul_vect\%configuration%\Yakovlev_Pavel_mul_vect.exe 100000
-  - cmd: mpiexec.exe -np 4 modules\task_1\Vdovin_Eugene_task1_NumWords\%configuration%\Vdovin_Eugene_task1_NumWords.exe 300000000
+  - cmd: mpiexec.exe -np 4 modules\task_1\Vdovin_Eugene_task1_NumWords\%configuration%\Vdovin_Eugene_task1_NumWords.exe 3000000

modules/task_1/vikhrev_array_sum/array_sum.cpp

@@ -8,20 +8,20 @@
 #define OutputSize 26
 
 int main(int argc, char* argv[])
-{   
+{
 	// mpi variables
 	int status, rank, size, nProc = 0;
-	double t1, t2;
+	double t1 = 0, t2 = 0;
 	//usual variables
 	int  cols,
 		 rows,
 		 arrSize,
 		 N; // number of elems that will be given to one process
-	double *arr, //matrix
+	double *arr = NULL, //matrix
 		   *buff, // buffer for messages
 		    partialSum = 0,
 		    arrSum = 0;
-	
+
 	//read argv
 	if (argc > 2)
 	{
@@ -34,27 +34,27 @@ int main(int argc, char* argv[])
 
 	//mpi part
 	status = MPI_Init(&argc, &argv);
-	assert(status == MPI_SUCCESS);
+	if (status != MPI_SUCCESS) { return -1; }
 
 	status = MPI_Comm_rank(MPI_COMM_WORLD, &rank);
-	assert(status == MPI_SUCCESS);
+	if (status != MPI_SUCCESS) { return -1; }
 
 	status = MPI_Comm_size(MPI_COMM_WORLD, &size);
-	assert(status == MPI_SUCCESS);
+	if (status != MPI_SUCCESS) { return -1; }
+
+	if (size > 64) return -1; // limit
 
-	if (size > 64) return -1; // limit 
-	
 	nProc = (arrSize >= size) ? size : arrSize;
 	N = arrSize / nProc;
-	
+
 	if (rank == MainProc) // sending
-	{	
+	{
 		//init arr
 		arr = new double[arrSize];
 		std::srand((unsigned)time(NULL));
 		for (int i = 0; i < arrSize; i++)
 			arr[i] = (std::rand()%100)/100.0;
-		
+
 		if (arrSize < OutputSize)
 		{
 			for (int i = 0; i < arrSize; i++)
@@ -66,23 +66,23 @@ int main(int argc, char* argv[])
 		}
 		std::cout << std::endl;
 		buff = arr;
-	
+
 		//sequential part
-		t1 = MPI_Wtime(); 
+		t1 = MPI_Wtime();
 		for (int i = 0; i < arrSize; i++)
 			arrSum += arr[i];
 		t2 = MPI_Wtime();
 		std::cout << "Sequential Time: " << t2 - t1 << std::endl;
 		std::cout << "Sequential Sum = " << arrSum << std::endl;
 		//end sequential part
-		
-		t1 = MPI_Wtime(); // start 
+
+		t1 = MPI_Wtime(); // start
 		for (int i = 1; i < nProc - 1; i++)
 			status = MPI_Send(&arr[i*N], N, MPI_DOUBLE, i, i, MPI_COMM_WORLD);
 
 		if (size != 1) // sending last part separately in case if arrSize % size != 0
 		    MPI_Send(&arr[N*(nProc - 1)], arrSize - N * (nProc - 1), MPI_DOUBLE, nProc - 1, nProc - 1, MPI_COMM_WORLD);
-	
+
 
 	}
 	else //receiving
@@ -100,16 +100,16 @@ int main(int argc, char* argv[])
 		}
 	}
 
-	//common part 
+	//common part
 	for (int i = 0; i < N; i++)
 		partialSum += buff[i];
-	
+
 	//sum
 	if (rank == MainProc)
-	{	
+	{
 		arrSum = 0;
 		arrSum += partialSum;
-		
+
 		for (int i = 1; i < size; i++)
 		{
 			MPI_Recv(&partialSum, 1, MPI_DOUBLE, MPI_ANY_SOURCE, 0, MPI_COMM_WORLD, MPI_STATUSES_IGNORE);
@@ -124,14 +124,14 @@ int main(int argc, char* argv[])
 	{
 		MPI_Send(&partialSum, 1, MPI_DOUBLE, MainProc, 0, MPI_COMM_WORLD);
 	}
-	
+
 	//del
 	if (rank == 0)
 		delete[] arr;
 	else
 		delete[] buff;
 
 	status = MPI_Finalize();
-	assert(status == MPI_SUCCESS);
+	if (status != MPI_SUCCESS) { return -1; }
 	return 0;
 }

modules/test_task/main.cpp

@@ -6,19 +6,19 @@ int main (int argc, char* argv[])
 {
     int status, rank, size;
     status = MPI_Init (&argc, &argv);
-    assert(status == MPI_SUCCESS);
+    if (status != MPI_SUCCESS) { return -1; }
 
     status = MPI_Comm_rank (MPI_COMM_WORLD, &rank);
-    assert(status == MPI_SUCCESS);
+    if (status != MPI_SUCCESS) { return -1; }
 
     status = MPI_Comm_size (MPI_COMM_WORLD, &size);
-    assert(status == MPI_SUCCESS);
+    if (status != MPI_SUCCESS) { return -1; }
 
     std::cout << "Process #" << rank << '\n';
     std::cout << "Count process: " << size << '\n';
 
     status = MPI_Finalize();
-    assert(status == MPI_SUCCESS);
-    
+    if (status != MPI_SUCCESS) { return -1; }
+
     return 0;
 }