Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice: Often only works after container restarts #18

Open
Sommerwiesel opened this issue Mar 8, 2024 · 4 comments
Open

Notice: Often only works after container restarts #18

Sommerwiesel opened this issue Mar 8, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@Sommerwiesel
Copy link

Sommerwiesel commented Mar 8, 2024

This is not a bug but something I noticed during the past days.
On my server, the rotation (and therefore the unblocking) only really takes effect after a container restart.
So, simply running the ipv6rotator will not (immediately) unblock the instance.
When I run ipv6rotate (my wrapper for /srv/ipv6rotate/smart-ipv6-rotator.py run --ipv6range=***) the blocking persists.
However, as soon as one of the instances restarts (during the hourly restart cron) it is unblocked.
And if i manually run ipv6rotate && systemctl restart [email protected] all of them restart and are unblocked.

@unixfox Do you have some advice whats the best practise at this point?
Should I just cron ipv6rotate and the restart of ALL containers hourly, together?

@unixfox
Copy link
Member

unixfox commented Mar 8, 2024

That is not normal, ipv6 routes should be reflected immediately. I have a feeling that something else related to invidious is acting up.

I have merged a PR that should help in youtube thinking that invidious is up to date now: iv-org/invidious#4473. Please check if it helps.

@Sommerwiesel
Copy link
Author

Sommerwiesel commented Mar 12, 2024

Is the PR already in 2024.03.08-99a5e9c?
If yes, didn't help.

I'm gonna change the hourly cron to do the ipv6rotate as well as restarting all containers for now, as a temporary hotfix.

@unixfox
Copy link
Member

unixfox commented Mar 12, 2024

Yes it's in the latest commit so 99a5e9c.

I can somewhat reproduce the issue on my end and I'm using kubernetes so this is different from a normal docker-compose install.

For now I do not have the free time to investigate the issue so I have also changed the restart of invidious to hourly restart.

@unixfox unixfox added the bug Something isn't working label May 22, 2024
@unixfox
Copy link
Member

unixfox commented Jun 6, 2024

Note to self: I have a feeling that it's related to some kind of "keepalive" HTTP in invidious that keeps the connection to YouTube servers: https://stackoverflow.com/questions/20763999/explain-http-keep-alive-mechanism

Maybe we should try to see if we can disable this functionality in the HTTP client and see if it's better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants