Videos: Fix missing host parameter on playback URLs when local=true
#4992
+26
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamantazFox
force-pushed
the
better-url-proxify
branch
from
17a83f9 to
7d0d573
Compare
SamantazFox
added
the
in-testing
syeopite
approved these changes
Nov 9, 2024
SamantazFox
force-pushed
the
better-url-proxify
branch
from
7d0d573 to
0270e0d
Compare
SamantazFox
force-pushed
the
better-url-proxify
branch
from
a4a5313 to
91c0ae4
Compare
SamantazFox
force-pushed
the
better-url-proxify
branch
from
91c0ae4 to
3ac8978
Compare
fpletz
approved these changes
Nov 15, 2024
13 tasks
unixfox
approved these changes
Jan 22, 2025
|
Oh it got merged. Did you guys tried livestreams? I had to revert https://github.com/iv-org/invidious/pull/4992/files#diff-8e4c5ae2068b27382f39df8cf4ebcb0a30c6252c91d4fe94cc3f71add850fac3L180-L181 because it didn't work for livestreams. (Don't test on my instance, I recently changed something and livestreams are broken) I tested it locally with the current standard setup of invidious (tokens and inv_sig_helper), no custom source code nor invidious-companion.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4850, the
host=parameter ceased to be added to videoplayback URLs by default, as it should only be added when the video is proxied through invidious.This change revealed that some parts of the code didn't properly "proxify" the playback URL (= adding back that
host=parameter) whenlocal=truewas passed to those endpoints.Thanks to @Fijxu for raising that problem!