Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement/Feature Request] Add confirmation page when leaving invidious to connect to youtube instead of immediately connecting to YouTube. #4798

Open
barkoder opened this issue Jul 19, 2024 · 3 comments · May be fixed by #4826
Labels
enhancement Improvement of an existing feature

Comments

@barkoder
Copy link

barkoder commented Jul 19, 2024

Is your enhancement request related to a problem? Please describe.

On at least 10 separate occasions, I have accidentally clicked/tapped "Watch on YouTube (Embed)" .

And also when I'm reading the comment section on links(text based web browser) using &nojs=1 , I have accidentally clicked/tapped on [YT] which links to the comment on youtube .

Describe the solution you'd like
I do not want to accidentally ping YouTube servers. Please implement a confirmation box page before connecting to YouTube.

A confirmation box page like...

** "You are leaving Invidious to visit <insert YouTube/comment link> . Are you Sure?" **

** "Yes" Or "No" **

Click "No" returns the page back to where the user was before.

Describe alternatives you've considered

I know modern web browsers(Firefox/Chromium) allow for editing the CSS, so I could just find the element and {display: none;} in Stylus, but this won't work in text based web browsers like links.

I realize this is entirely a user error(my error), and I've tried to be careful not to click YT links, but I've failed so many times now.
So I thought I'd propose this feature request. Please consider it.

Thanks!

@barkoder barkoder added the enhancement Improvement of an existing feature label Jul 19, 2024
@unixfox
Copy link
Member

unixfox commented Jul 19, 2024

Can only be implemented using javascript though, if you have JS disabled you will never get the popup.

@SamantazFox
Copy link
Member

We can do what we do for the delete playlist/account actions, though: an intermediary HTML page with two buttons.

@barkoder barkoder changed the title [Enhancement/Feature Request] Add confirmation box when leaving invidious to connect to youtube instead of immediately connecting to YouTube. [Enhancement/Feature Request] Add confirmation page when leaving invidious to connect to youtube instead of immediately connecting to YouTube. Jul 20, 2024
@barkoder
Copy link
Author

barkoder commented Jul 20, 2024

Yes! Thank you @SamantazFox

That's actually what I had in mind while I was writing the issue. Something like this - https://steamcommunity.com/linkfilter/?u=https%3A%2F%2Fexample.com

I shouldn't have used the word confirmation "box". I meant confirmation "page" .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants