Skip to content
This repository was archived by the owner on Oct 21, 2022. It is now read-only.

Latest commit

 

History

History
26 lines (22 loc) · 941 Bytes

pull_request_template.md

File metadata and controls

26 lines (22 loc) · 941 Bytes

This PR is not ready for review

Before requesting a review, please make a checklist for the reviewer to follow and check off. This helps guide the reviewer to give meaningful feedback rather than perfunctory "approval." Start with the required section.

Required

Pivotal story

To be completed by PR reviewer

  • Testing - code has
    • thorough tests
    • surface level tests
    • testing not needed
  • Speed / Performance - application will be
    • probably faster
    • probably slower
    • hard to tell based on the code or N/A
  • Stability - code is
    • likely to introduce bugs / race conditions
    • not likely to introduce bugs / race conditions
  • Security - code is
    • likely to introduce security issues
    • not likely introduce security issues
  • "Smell Test" - documentation, readability, and cleanliness
    • passes
    • fails