Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering requests by method #404

Closed
mortenscheel opened this issue Jul 2, 2020 · 3 comments
Closed

Allow filtering requests by method #404

mortenscheel opened this issue Jul 2, 2020 · 3 comments

Comments

@mortenscheel
Copy link
Contributor

It would be nice to be able to filter requests by method.
With cross-origin AJAX requests, clockwork logs every single OPTIONS preflight request, which is kind of meaningless. Maybe these should be ignored except if explicitly included in a config setting.

@itsgoingd
Copy link
Owner

hey, ability to filter requests by closure is already on the todo list (#403)

ignoring pre-flight requests by default makes a lot of sense, adding that one as well. i've never noticed this being an issue with laravel though, are you using the vanilla integration?

@mortenscheel
Copy link
Contributor Author

I'm using Sanctum for auth on the backend, and the frontend is a SPA on a different subdomain. Hence the cross-origin requests.

@itsgoingd
Copy link
Owner

i've released clockwork 4.1.6 with support for filtering requests by method (options requests are filtered by default)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants