Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubernetes task deletion logic is flawed #647

Open
0x2b3bfa0 opened this issue Aug 29, 2022 · 0 comments
Open

Kubernetes task deletion logic is flawed #647

0x2b3bfa0 opened this issue Aug 29, 2022 · 0 comments
Assignees
@tasdomas

Comments

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Aug 29, 2022 •
edited
Loading

Extracted from #645 (comment)

It's either a bug or some weird workaround @0x2b3bfa0 forgot to document. Sounds like a bug.

terraform-provider-iterative/task/k8s/task.go

Lines 205 to 207 in 7b27c57

// WTH?
Description: "Deleting ephemeral Job to retrieve directory...",
Action: withEnv(env, t.Resources.Job.Create),

Should read t.Resources.Job.Delete instead of t.Resources.Job.Create but changing it breaks the tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tasdomas tasdomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tasdomas @0x2b3bfa0