task Fix id-generation (#631)

* Fix id-generation

:hear_no_evil: Much sad! 8 hrs of debugging for such a small fix :see_no_evil:

* update stability test

* consistent test

* Revert "update stability test"

This reverts commit 4d5848a.

Author: dacbd

task/common/identifier.go

@@ -41,7 +41,7 @@ func NewRandomIdentifier() Identifier {
 
 func (i Identifier) Long() string {
 	name := normalize(string(i), maximumLongLength-shortLength-uint32(len("tpi---")))
-	digest := hash(string(i), shortLength/2)
+	digest := hash(name, shortLength/2)
 
 	return fmt.Sprintf("tpi-%s-%s-%s", name, digest, hash(name+digest, shortLength/2))
 }

task/common/identifier_test.go

@@ -9,14 +9,22 @@ import (
 
 func TestIdentifier(t *testing.T) {
 	name := gofakeit.NewCrypto().Sentence(512)
-
 	t.Run("stability", func(t *testing.T) {
 		identifier := NewIdentifier(name)
 
 		require.Equal(t, identifier.Long(), identifier.Long())
 		require.Equal(t, identifier.Short(), identifier.Short())
 	})
 
+	t.Run("consistent", func(t *testing.T) {
+		identifier := NewIdentifier("5299fe10-79e9-4c3b-b15e-036e8e60ab6c")
+		parsed, err := ParseIdentifier(identifier.Long())
+
+		require.NoError(t, err)
+		require.Equal(t, identifier.Long(), parsed.Long())
+		require.Equal(t, identifier.Short(), parsed.Short())
+	})
+
 	t.Run("homogeneity", func(t *testing.T) {
 		identifier := NewIdentifier(name)