Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider migrating away from docker-py #31

Open
dtrifiro opened this issue Jul 25, 2022 · 3 comments
Open

Consider migrating away from docker-py #31

dtrifiro opened this issue Jul 25, 2022 · 3 comments

Comments

@dtrifiro
Copy link
Contributor

While very convenient, docker-py is currently unmaintaned (see docker/docker-py#2989), so we might want to consider migrating away from it.

A solution which does not require introducing new dependencies would replacing the docker_client fixture with a wrapper calling docker through subprocess.run.

@dtrifiro dtrifiro changed the title consider migrating away from docker-py Consider migrating away from docker-py Jul 25, 2022
@dtrifiro
Copy link
Contributor Author

It seems that development for docker-py resumed. I'll leave this open for now and get back to this in a few months

@dtrifiro
Copy link
Contributor Author

Another point against docker-py is tag updating.
docker tags be updated automatically Dependabot or Renovate, when specified in docker-compose.yml or Dockerfile files, but since we define tags in the code, these tools won't work.

Migrating to pytest-docker could be a solution, although it could be tricky to only bring up specific containers.

@skshetry
Copy link
Member

You can update the version that you have in the code using renovate’s regex manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants