Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Unnecessary param in mlem create deployment #227

Closed
aguschin opened this issue May 6, 2022 · 4 comments
Closed

Unnecessary param in mlem create deployment #227

aguschin opened this issue May 6, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@aguschin
Copy link
Contributor

aguschin commented May 6, 2022

If you already created an env, why you should specify this again when creating deploy?
Example:

$ mlem create env heroku staging  # note HEROKU
💾 Saving env to staging.mlem

$ mlem create deployment heroku myservice -c app_name=mlem-quick-start -c model=rf -c env=staging  # HEROKU again
💾 Saving deployment to myservice.mlem

Seems like unnecessary duplication, but maybe I'm missing something.

@aguschin aguschin added the bug Something isn't working label May 6, 2022
@aguschin
Copy link
Contributor Author

related to #233

@jorgeorpinel
Copy link
Contributor

May be related to #267 as well.

@aguschin
Copy link
Contributor Author

May be fixed by #363

@mike0sv
Copy link
Contributor

mike0sv commented Sep 1, 2022

It will be partly fixed. It will allow to skip env entirely, but if you want to set up some env params, you will probably still need to specify env type

@aguschin aguschin closed this as completed Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants